Review main Merged

78647[BUGFIX] Mitigate incorrect libxml usage of "enshrined/svg-sanitize"

Stefan Bürk CR +2 V +2 Easy +13 −8 updated 04/15/23, 08:50

Commit message

External "enshrined/svg-sanitize" package uses
`libxml_use_internal_errors()`, but fails to
clear errors using libxml_clear_errors().

This can lead to side effects with subsequest
libxml usages.

An upstream patch to fix this is pending,
but it needs to be merged and released.

In the meantime, we mitigate the issue in
our wrapper class.

See: https://github.com/darylldoyle/svg-sanitizer/pull/90

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Stefan Bürk uploaded patch set 1 04/14/23, 22:12

  2. Stefan Bürk updated the commit message in patch set 2 04/14/23, 22:23

  3. core-ci voted on patch set 1 V -1 04/14/23, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40648

  4. Christian Kuhn uploaded patch set 3 04/14/23, 22:28

  5. core-ci voted on patch set 2 V -1 04/14/23, 22:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40649

  6. Christian Kuhn uploaded patch set 4 04/14/23, 22:35

  7. core-ci voted on patch set 3 V -1 04/14/23, 22:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40650

  8. core-ci voted on patch set 4 V +1 04/14/23, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40652

  9. Stefan Bürk voted on patch set 4 V +1 CR +1 04/14/23, 22:49

  10. Christian Kuhn commented on patch set 4 V +2 CR +2 04/14/23, 22:59

    we know this is correct. we need this as a pre-patch and will merge now.
  11. Christian Kuhn merged patch set 5 04/14/23, 22:59

  12. Benni Mack commented on patch set 5 V +1 CR +1 04/15/23, 08:09

    nice one
  13. Oliver Hader voted on patch set 5 CR +1 04/15/23, 08:50