Review 11.5 Merged

78648[BUGFIX] Mitigate incorrect libxml usage of "enshrined/svg-sanitize"

Christian Kuhn CR +2 V +2 Easy +13 −8 updated 04/15/23, 08:49

Commit message

External "enshrined/svg-sanitize" package uses
`libxml_use_internal_errors()`, but fails to
clear errors using libxml_clear_errors().

This can lead to side effects with subsequest
libxml usages.

An upstream patch to fix this is pending,
but it needs to be merged and released.

In the meantime, we mitigate the issue in
our wrapper class.

See: https://github.com/darylldoyle/svg-sanitizer/pull/90

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Christian Kuhn uploaded patch set 1 04/14/23, 22:33

  2. Christian Kuhn uploaded patch set 2 04/14/23, 22:36

  3. core-ci voted on patch set 1 V -1 04/14/23, 22:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40651

  4. core-ci voted on patch set 2 V +1 04/14/23, 22:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40653

  5. Christian Kuhn voted on patch set 2 V +2 CR +2 04/14/23, 23:00

  6. Christian Kuhn merged patch set 3 04/14/23, 23:00

  7. Oliver Hader voted on patch set 3 CR +1 04/15/23, 08:49