Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

78652[WIP][TASK] Introduce PageRenderer resource models

Oliver Hader CR 0 V -1 Hard +514 −153 updated 04/22/23, 11:07

Commit message

Instead of extending `PageRenderer` methods by method params again
and again, instructions are encapsulated in data transfer objects.
For backward compatibility reasons, these objects can still be used
as arrays when reading data - modifying array data is not supported.

* current invocation
  $pageRenderer->addCssFile('file.css', 'stylesheet', 'all', 'my-title');
* potential future invocation
  $styleSheetFile = new StyleSheetFileDto('file.css');
  $styleSheetFile->title = 'my-title';
  $pageRenderer->addCssFile($styleSheetFile);

Adding new aspects and behavior to `StyleSheetFileDto` seems to be
simpler and does not require to adjust all involved methods that are
just transferring the data to the final compressor/renderer.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/78652/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/78652/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Files 14

Review log 610

  1. Oliver Hader uploaded patch set 1 04/15/23, 10:58

  2. Oliver Hader uploaded patch set 2 04/15/23, 10:58

  3. core-ci voted on patch set 1 V -1 04/15/23, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40674

  4. core-ci voted on patch set 2 V -1 04/15/23, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40675

  5. Oliver Hader uploaded patch set 3 V -1 04/15/23, 12:13

  6. Oliver Hader commented on patch set 3 04/15/23, 12:15

    PageRenderer.php:1366 Unresolved

    maybe introduce new `addStyleSheetFile()` instead
  7. core-ci voted on patch set 3 V -1 04/15/23, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40677

  8. Oliver Hader uploaded patch set 4 V -1 04/15/23, 18:31

  9. core-ci voted on patch set 4 V -1 04/15/23, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40694

  10. Oliver Hader marked it work in progress 04/22/23, 11:07