78660[BUGFIX] Handle dynamic CSP nonce values during frontend rendering
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/frontend/Classes/Cache/NonceValueSubstitution.phpnew+36 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+16 −12
- typo3/sysext/frontend/Classes/Http/RequestHandler.php6+18 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Assets/app.cssnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Assets/app.jsnew+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/RequestHandler.typoscriptnew+15 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/RequestHandlerTest.phpnew+118 −0
Review log 3451
Show 1526 earlier messages
-
Oliver Hader uploaded patch set 1 04/15/23, 21:06
-
core-ci voted on patch set 1 V +1 04/15/23, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40712
-
Oliver Hader uploaded patch set 2
V +104/16/23, 08:00 -
Oliver Hader uploaded patch set 3 04/16/23, 08:30
-
Oliver Hader uploaded patch set 4 04/16/23, 08:32
-
core-ci voted on patch set 2 V -1 04/16/23, 08:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40728
-
core-ci voted on patch set 4 V -1 04/16/23, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40730
-
Oliver Hader uploaded patch set 5
V -104/16/23, 12:14 -
core-ci voted on patch set 5 V -1 04/16/23, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40736
-
Oliver Hader uploaded patch set 6
V -104/16/23, 13:21 -
core-ci voted on patch set 6 V +1 04/16/23, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40741
-
Oliver Hader uploaded patch set 7
V +104/19/23, 14:02 -
core-ci voted on patch set 7 V -1 04/19/23, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40901
-
Oliver Hader uploaded patch set 8
V -104/19/23, 14:37 -
core-ci voted on patch set 8 V -1 04/19/23, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40908
-
Oliver Hader uploaded patch set 9
V -104/19/23, 15:56 -
core-ci voted on patch set 9 V +1 04/19/23, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40917
-
Oliver Hader uploaded patch set 10
V +104/20/23, 10:33 -
core-ci voted on patch set 10 V +1 04/20/23, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40957
-
Oliver Hader voted on patch set 10 CR -1 04/20/23, 15:57
-
Oliver Hader uploaded patch set 11
CR -1V +104/20/23, 16:04 -
core-ci voted on patch set 11 V +1 04/20/23, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40995
-
Oliver Hader uploaded patch set 12
V +104/20/23, 17:03 -
core-ci voted on patch set 12 V -1 04/20/23, 18:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41004
-
Oliver Hader uploaded patch set 13
V -104/20/23, 19:19 -
Oliver Hader uploaded patch set 14 04/20/23, 20:23
-
Benni Mack commented on patch set 14 04/20/23, 20:26
looks about right, can we have one functional for this, so we know it's working even if I fiddle around with intINCscript at a later point? -
core-ci voted on patch set 13 V -1 04/20/23, 20:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41006
-
core-ci voted on patch set 14 V -1 04/20/23, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41008
-
Oliver Hader commented on patch set 14 04/21/23, 12:29
Reply
I don't know how to really test this, since functionals are not using a sub-request (as different process) anymore, but embed the logic in the very same PHP process. -
Oliver Hader commented on patch set 15
V -104/21/23, 12:31Published edit on patch set 14. -
Oliver Hader updated the commit message in patch set 16 04/21/23, 12:34
-
core-ci voted on patch set 16 V +1 04/21/23, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41033
-
Oliver Hader marked it work in progress 04/21/23, 12:47
-
Oliver Hader uploaded patch set 17
V +104/21/23, 14:08 -
Oliver Hader commented on patch set 17 04/21/23, 14:11
This change is ready for review.I've added a test case now - however, caching cannot be tested right now since it's disabled (and overridden) in `FunctionalTestCase` -
core-ci voted on patch set 17 V +1 04/21/23, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41039
-
Oliver Hader uploaded patch set 18
V +104/21/23, 20:25 -
core-ci voted on patch set 18 V -1 04/21/23, 21:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41064
-
Oliver Hader uploaded patch set 19
V -104/21/23, 22:53 -
core-ci voted on patch set 19 V +1 04/21/23, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41070
-
Georg Ringer voted on patch set 19 CR +1 04/23/23, 06:31
-
Benni Mack commented on patch set 19 04/24/23, 12:29
RequestHandler.php:143can we use !empty() as count is more expensive -
Andreas Kienast commented on patch set 19 04/24/23, 12:51
RequestHandler.php:143ReplyAFACS, `count()` refers to `ConsumableString`, which implements `\Countable` that returns the value of an internal counter. -
Oliver Hader commented on patch set 19 04/24/23, 12:51
RequestHandler.php:143ReplyThis won't work - `$nonce` is a `Countable`, but `!emtpy($nonce)` will always be true, since if checks the object (which is not empty). An alternative would be `$nonce->count() !== 0`... -
Benni Mack commented on patch set 19 04/24/23, 12:52
RequestHandler.php:143Replyfine then -
Oliver Hader commented on patch set 19 04/24/23, 12:52
RequestHandler.php:143Reply(what Andy said 😊) -
Oliver Hader commented on patch set 19 04/24/23, 12:54
RequestHandler.php:143ReplyDone -
Andreas Kienast voted on patch set 19 V +1 CR +1 04/24/23, 13:10
-
Georg Ringer voted on patch set 19 V +2 CR +2 04/24/23, 13:22
-
Georg Ringer merged patch set 20 04/24/23, 13:22