Review main Merged

78661[TASK] Update display and markup of user settings form

Jasmina Ließmann CR +2 V +2 Normal +120 −105 updated 04/24/23, 18:15

Commit message

Previously, the form fields in user settings form were displayed in
their entirety, filling the screen.

With this patch, the width of the input mask is now reduced to create
a uniform appearance with forms of the form engine. Some individual
spacing between the form fields has also been adjusted to match those
of the form engine.

The buttons for adding or removing an avatar image now each contain
speaking labels that were previously only aria-labels.

Additionally, the form fields markup in the user settings has been
updated to fully match the FormEngine form field markup.
With this we create the prerequisite that rollouts of global style
adjustments for form fields also work on this form.
Mid-term, this module should be using FormEngine for rendering anyway,
so this is kind of a pre-patch.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1527

Show 12 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 04/15/23, 22:05

  2. core-ci voted on patch set 1 V -1 04/15/23, 22:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40714

  1. Jasmina Ließmann uploaded patch set 2 V -1 04/15/23, 22:19

  2. core-ci voted on patch set 2 V +1 04/15/23, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40717

  3. Jasmina Ließmann uploaded patch set 3 V +1 04/15/23, 22:49

  4. core-ci voted on patch set 3 V +1 04/15/23, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40719

  5. Jasmina Ließmann uploaded patch set 4 V +1 04/15/23, 23:07

  6. core-ci voted on patch set 4 V +1 04/15/23, 23:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40721

  7. Jasmina Ließmann uploaded patch set 5 V +1 04/16/23, 17:10

  8. core-ci voted on patch set 5 V +1 04/16/23, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40757

  9. Jasmina Ließmann uploaded patch set 6 V +1 04/16/23, 19:19

  10. core-ci voted on patch set 6 V +1 04/16/23, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40765

  11. Jasmina Ließmann uploaded patch set 7 V +1 04/19/23, 18:55

  12. core-ci voted on patch set 7 V +1 04/19/23, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40929

  13. Jasmina Ließmann uploaded patch set 8 V +1 04/24/23, 15:38

  14. core-ci voted on patch set 8 V +1 04/24/23, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41177

  15. Jasmina Ließmann uploaded patch set 9 V +1 04/24/23, 17:08

  16. Jasmina Ließmann uploaded patch set 10 04/24/23, 17:16

  17. core-ci voted on patch set 9 V +1 04/24/23, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41181

  18. core-ci voted on patch set 10 V +1 04/24/23, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41182

  19. Jasmina Ließmann uploaded patch set 11 V +1 04/24/23, 17:39

  20. Jasmina Ließmann updated the commit message in patch set 12 04/24/23, 17:48

  21. core-ci voted on patch set 11 V +1 04/24/23, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41183

  22. core-ci voted on patch set 12 V +1 04/24/23, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41184

  23. Christian Kuhn voted on patch set 12 V +1 CR +1 04/24/23, 18:10

  24. Stefan Bürk voted on patch set 12 V +2 CR +2 04/24/23, 18:15

  25. Stefan Bürk merged patch set 13 04/24/23, 18:15