Review main Merged

78662[TASK] Deprecate unused class MagicImageService

Frank Nägler CR +2 V +2 Easy +48 −0 updated 04/17/23, 10:16

Commit message

The class MagicImageService is deprecated, since
it's unused since version 10, due to removal of
EXT:rtehtmlarea.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stephan Großberndt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1215

  1. Frank Nägler uploaded patch set 1 04/16/23, 10:33

  2. Oliver Klee commented on patch set 1 04/16/23, 10:40

    Please also let‘s make this scannable.
  3. core-ci voted on patch set 1 V +1 04/16/23, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40731

  4. Chris Müller updated the commit message in patch set 2 V +1 04/16/23, 11:11

  5. Chris Müller commented on patch set 2 04/16/23, 11:14

    Deprecation-99237-MagicImageService.rst:25

    it's => its
  6. core-ci voted on patch set 2 V +1 04/16/23, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40735

  7. Benni Mack commented on patch set 2 04/16/23, 14:08

    thanks for the clean up a few regards. also, yes. ExtensionScanner files is missing as Oli suggested.

    Deprecation-99237-MagicImageService.rst:16

    maybe we can explain that this code was needed for EXT:rtehtmlarea and is not used for inline images in ckeditor (which supports images in rte but not as "magic images").

    Deprecation-99237-MagicImageService.rst:38

    Migration could be to just copy the class into the extension and rely on that?
  8. Oli Bartsch commented on patch set 2 04/17/23, 08:47

    MagicImageService.php:49

    Shouldn't it be enough to just deprecate the class? Let's add an entry in ClassNameMatcher and additionally trigger a deprecation log entry in the conctructor.
  9. Christian Kuhn commented on patch set 2 04/17/23, 08:50

    shorten title by avoiding full namespace of class, please.
  10. Oli Bartsch uploaded patch set 3 V +1 04/17/23, 09:47

  11. Oli Bartsch commented on patch set 3 V +1 CR +1 04/17/23, 09:48

    Reply

    Done

    Reply

    Done

    MagicImageService.php:49 Reply

    Done

    Deprecation-99237-MagicImageService.rst:16 Reply

    Done

    Deprecation-99237-MagicImageService.rst:25 Reply

    Done

    Deprecation-99237-MagicImageService.rst:38 Reply

    Done
  12. core-ci voted on patch set 3 V +1 04/17/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40791

  13. Stephan Großberndt voted on patch set 3 CR +1 04/17/23, 09:58

  14. Benni Mack voted on patch set 3 V +2 CR +2 04/17/23, 10:16

  15. Benni Mack merged patch set 4 04/17/23, 10:16