78662[TASK] Deprecate unused class MagicImageService
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stephan Großberndt +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1215
-
Frank Nägler uploaded patch set 1 04/16/23, 10:33
-
Oliver Klee commented on patch set 1 04/16/23, 10:40
Please also let‘s make this scannable. -
core-ci voted on patch set 1 V +1 04/16/23, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40731
-
Chris Müller updated the commit message in patch set 2
V +104/16/23, 11:11 -
Chris Müller commented on patch set 2 04/16/23, 11:14
Deprecation-99237-MagicImageService.rst:25it's => its -
core-ci voted on patch set 2 V +1 04/16/23, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40735
-
Benni Mack commented on patch set 2 04/16/23, 14:08
thanks for the clean up a few regards. also, yes. ExtensionScanner files is missing as Oli suggested.Deprecation-99237-MagicImageService.rst:16maybe we can explain that this code was needed for EXT:rtehtmlarea and is not used for inline images in ckeditor (which supports images in rte but not as "magic images").Deprecation-99237-MagicImageService.rst:38Migration could be to just copy the class into the extension and rely on that? -
Oli Bartsch commented on patch set 2 04/17/23, 08:47
MagicImageService.php:49Shouldn't it be enough to just deprecate the class? Let's add an entry in ClassNameMatcher and additionally trigger a deprecation log entry in the conctructor. -
Christian Kuhn commented on patch set 2 04/17/23, 08:50
shorten title by avoiding full namespace of class, please. -
Oli Bartsch uploaded patch set 3
V +104/17/23, 09:47 -
Oli Bartsch commented on patch set 3 V +1 CR +1 04/17/23, 09:48
Reply
DoneReply
DoneMagicImageService.php:49ReplyDoneDeprecation-99237-MagicImageService.rst:16ReplyDoneDeprecation-99237-MagicImageService.rst:25ReplyDoneDeprecation-99237-MagicImageService.rst:38ReplyDone -
core-ci voted on patch set 3 V +1 04/17/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40791
-
Stephan Großberndt voted on patch set 3 CR +1 04/17/23, 09:58
-
Benni Mack voted on patch set 3 V +2 CR +2 04/17/23, 10:16
-
Benni Mack merged patch set 4 04/17/23, 10:16