78663[BUGFIX] Prevent unecessary usage of inline javascript in href attributes
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Oliver Hader +1
-
Verified V +2 Done
- Georg Ringer +2
- core-ci +1 CI
Issues 1
Files 14
- Build/Sources/Sass/component/_resources.scss+11 −13
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+2 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −2
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileOperationsCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineContentElementLocalizeSynchronizeCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlinePagesLocalizeResourceCest.php+2 −2
- typo3/sysext/filelist/Classes/FileList.php+28 −25
- typo3/sysext/filelist/Resources/Private/Templates/Filelist/Tiles.html+2 −2
- typo3/sysext/reactions/Resources/Private/Templates/Management/Overview.html+2 −2
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule.html+2 −2
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+3 −3
- typo3/sysext/webhooks/Resources/Private/Templates/Management/Overview.html+2 −2
- typo3/sysext/workspaces/Resources/Private/Partials/WorkingTable.html2+2 −2
Review log 2129
Show 34 earlier messages
-
Frank Nägler uploaded patch set 1 04/16/23, 10:54
-
core-ci voted on patch set 1 V +1 04/16/23, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40732
-
Oliver Klee updated the commit message in patch set 2
V +104/16/23, 11:09 -
Oliver Klee updated the commit message in patch set 3 04/16/23, 11:10
-
core-ci voted on patch set 3 V +1 04/16/23, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40734
-
Oliver Hader voted on patch set 3 CR +1 04/16/23, 11:28
-
Oliver Hader commented on patch set 3 04/16/23, 11:31
Usually the event handler would prevent the default behavior - seems to be better this way with using a non-existing anchor 👍 -
core-ci voted on patch set 2 V +1 04/16/23, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40733
-
Oliver Klee voted on patch set 3 CR +1 04/16/23, 13:05
-
Oli Bartsch commented on patch set 3 04/17/23, 09:24
WorkingTable.html:57Having empty targets usually means that this should be a <button> instead. -
Oliver Klee voted on patch set 3 CR 0 04/17/23, 09:58
-
Oli Bartsch uploaded patch set 4
CR +1V +104/17/23, 13:49 -
Oli Bartsch commented on patch set 4 V +1 CR +1 04/17/23, 13:50
WorkingTable.html:57ReplyDone -
core-ci voted on patch set 4 V -1 04/17/23, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40809
-
Oli Bartsch uploaded patch set 5
CR +1V +104/17/23, 14:20 -
core-ci voted on patch set 5 V -1 04/17/23, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40811
-
Oli Bartsch uploaded patch set 6
V -104/17/23, 14:59 -
core-ci voted on patch set 6 V -1 04/17/23, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40816
-
Oli Bartsch uploaded patch set 7
V -104/17/23, 17:18 -
core-ci voted on patch set 7 V +1 04/17/23, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40823
-
Oli Bartsch voted on patch set 7 V +1 CR +1 04/17/23, 17:27
-
Oliver Klee updated the commit message in patch set 8
CR +1V +104/17/23, 18:56 -
Oliver Klee voted on patch set 8 CR +1 04/17/23, 18:57
-
core-ci voted on patch set 8 V +1 04/17/23, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40835
-
Georg Ringer voted on patch set 8 V +2 CR +2 04/17/23, 19:45
-
Georg Ringer merged patch set 9 04/17/23, 19:45
-
Andreas Kienast commented on patch set 9 04/18/23, 08:51
post -1: this patch breaks the tile view in EXT:filelist -
Frank Nägler commented on patch set 9 04/18/23, 10:57
looks like CSS issue with button element and btn class. -
Oliver Hader voted on patch set 9 CR +1 04/20/23, 16:18