Review main Merged

78663[BUGFIX] Prevent unecessary usage of inline javascript in href attributes

Frank Nägler CR +2 V +2 Normal +63 −63 updated 04/20/23, 16:18

Commit message

Replace all `<a> ` tags having `href=“javascript:;“` as target
with `<button>` tags of type `button` and appropriate classes.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 14

Review log 2129

Show 34 earlier messages
  1. Frank Nägler uploaded patch set 1 04/16/23, 10:54

  2. core-ci voted on patch set 1 V +1 04/16/23, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40732

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/16/23, 11:09

  4. Oliver Klee updated the commit message in patch set 3 04/16/23, 11:10

  1. core-ci voted on patch set 3 V +1 04/16/23, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40734

  2. Oliver Hader voted on patch set 3 CR +1 04/16/23, 11:28

  3. Oliver Hader commented on patch set 3 04/16/23, 11:31

    Usually the event handler would prevent the default behavior - seems to be better this way with using a non-existing anchor 👍
  4. core-ci voted on patch set 2 V +1 04/16/23, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40733

  5. Oliver Klee voted on patch set 3 CR +1 04/16/23, 13:05

  6. Oli Bartsch commented on patch set 3 04/17/23, 09:24

    WorkingTable.html:57

    Having empty targets usually means that this should be a <button> instead.
  7. Oliver Klee voted on patch set 3 CR 0 04/17/23, 09:58

  8. Oli Bartsch uploaded patch set 4 CR +1 V +1 04/17/23, 13:49

  9. Oli Bartsch commented on patch set 4 V +1 CR +1 04/17/23, 13:50

    WorkingTable.html:57 Reply

    Done
  10. core-ci voted on patch set 4 V -1 04/17/23, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40809

  11. Oli Bartsch uploaded patch set 5 CR +1 V +1 04/17/23, 14:20

  12. core-ci voted on patch set 5 V -1 04/17/23, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40811

  13. Oli Bartsch uploaded patch set 6 V -1 04/17/23, 14:59

  14. core-ci voted on patch set 6 V -1 04/17/23, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40816

  15. Oli Bartsch uploaded patch set 7 V -1 04/17/23, 17:18

  16. core-ci voted on patch set 7 V +1 04/17/23, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40823

  17. Oli Bartsch voted on patch set 7 V +1 CR +1 04/17/23, 17:27

  18. Oliver Klee updated the commit message in patch set 8 CR +1 V +1 04/17/23, 18:56

  19. Oliver Klee voted on patch set 8 CR +1 04/17/23, 18:57

  20. core-ci voted on patch set 8 V +1 04/17/23, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40835

  21. Georg Ringer voted on patch set 8 V +2 CR +2 04/17/23, 19:45

  22. Georg Ringer merged patch set 9 04/17/23, 19:45

  23. Andreas Kienast commented on patch set 9 04/18/23, 08:51

    post -1: this patch breaks the tile view in EXT:filelist
  24. Frank Nägler commented on patch set 9 04/18/23, 10:57

    looks like CSS issue with button element and btn class.
  25. Oliver Hader voted on patch set 9 CR +1 04/20/23, 16:18