Review main Merged

78666[TASK] Use non-namepaced arguments in ext:form

Christian Kuhn CR +2 V +2 Easy +14 −23 updated 04/16/23, 14:18

Commit message

Feature #97096 introduced a toggle to skip
namespaces in extbase backend modules to
beautify backend links.

The default is to enabled shortened links, but
ext:form toggles this off.

The patch removes the default override and
adapts some ext:form links to make it work.

Note the ext:form module currently suffers from
a regression of #98604 - the form editor JS init
logic seems to have a race condition and crashes
"sometimes". This is not related to this patch
and needs to be handled with another patch.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 68

  1. Christian Kuhn uploaded patch set 1 04/16/23, 13:40

  2. Christian Kuhn updated the commit message in patch set 2 04/16/23, 13:44

  3. core-ci voted on patch set 1 V +1 04/16/23, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40742

  4. core-ci voted on patch set 2 V +1 04/16/23, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40743

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 04/16/23, 14:06

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 04/16/23, 14:11

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 04/16/23, 14:18

  8. Stefan Bürk merged patch set 3 04/16/23, 14:18