Review main Merged

78671[TASK] Avoid usage of LanguageService->includeLLFile in ext:adminpanel

Anja Leichsenring CR +2 V +2 Easy +1 −3 updated 04/17/23, 08:10

Commit message

The extension does not use any globally loaded labels, so the usage
of the function to load the labels globally can safely be removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Anja Leichsenring uploaded patch set 1 04/16/23, 19:16

  2. core-ci voted on patch set 1 V +1 04/16/23, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40764

  3. Jasmina Ließmann uploaded patch set 2 V +1 04/16/23, 19:43

  4. core-ci voted on patch set 2 V +1 04/16/23, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40768

  5. Jörg Bösche voted on patch set 2 CR +1 04/17/23, 07:36

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 04/17/23, 07:54

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 04/17/23, 08:00

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 04/17/23, 08:10

  9. Christian Kuhn merged patch set 3 04/17/23, 08:10