Review main Merged

78681[TASK] Remove option for enabling RTE per user

Benni Mack CR +2 V +2 Normal +41 −85 updated 04/18/23, 13:43

Commit message

Because RTE was not always possible in all browsers
in TYPO3 v3.x, a flag to deactivate the RTE
(for Netsacpe users) was added.

Since then, HTMLarea and now CKEditor4 (or with
v12: CKEditor 5) work properly across all
browsers and the setting has no effect anymore,
is therefore removed from the UI.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 913

  1. Benni Mack uploaded patch set 1 04/17/23, 08:44

  2. Christian Kuhn updated the commit message in patch set 2 04/17/23, 08:45

  3. core-ci voted on patch set 2 V -1 04/17/23, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40789

  4. core-ci voted on patch set 1 V -1 04/17/23, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40787

  5. Georg Ringer commented on patch set 2 V +1 CR +1 04/18/23, 06:48

    should we write an RST?
  6. Christian Kuhn commented on patch set 2 CR -1 04/18/23, 08:09

    yeah. benni will add an important.rst and will somehow fix ci as well, i suppose.
  7. Benni Mack uploaded patch set 3 CR +1 V +1 04/18/23, 12:52

  8. core-ci voted on patch set 3 V -1 04/18/23, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40873

  9. Christian Kuhn uploaded patch set 4 V -1 04/18/23, 13:30

  10. core-ci voted on patch set 4 V +1 04/18/23, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40876

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 04/18/23, 13:38

  12. Andreas Kienast voted on patch set 4 V +2 CR +2 04/18/23, 13:43

  13. Andreas Kienast merged patch set 5 04/18/23, 13:43