Review main Merged

78682[TASK] Streamline spacings

Benjamin Kott CR +2 V +2 Expert +1239 −919 updated 04/20/23, 13:10

Commit message

General spacings have been streamlined that are most relevant for
CSS declarations that add `margin-bottom` to ensure there is space
available to the next element.

Headlines h1, h2, and h3 will not add additional space to the top if
they are used in a document flow and are not the first element, and
have no classes assigned. This provides a visual divider when a
new content section is opened while keeping existing styles untouched.

There are edge cases where it can be necessary to add the space
manually because some additional necessary nesting is in place. For
this case, the class `.headline-spaced` was introduced. This class is
limited to h1, h2, and h3 and should be used with care.

The code styling for <pre> and <code> has been adjusted when
`[class*="language-"]` is matching. While we have no automatic syntax
highlighting for this kind of area yet, this indicates that a user
wants to highlight a section of code.

Dropping row and col implementations for inline forms. We are
introducing `.form-row` and respective variants to different viewports
`.form-row-*` to have more control over spacing for inline forms.

Each input element will consume the necessary space it needs and
wrap if not enough space is available.

The spacing for clearable elements is now applied to
`.form-control-clearable`. This allows the spacing adjustments to be
present before the JavaScript is invoked. The class will be added
through js if not already present on the element. This avoids
additional layout shifts.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 103

Show 83 more files

Review log 2747

Show 1122 earlier messages
  1. Benjamin Kott uploaded patch set 1 04/17/23, 09:37

  2. core-ci voted on patch set 1 V +1 04/17/23, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40790

  3. Benjamin Kott uploaded patch set 2 V +1 04/17/23, 14:51

  4. Benjamin Kott uploaded patch set 3 04/17/23, 14:52

  5. core-ci voted on patch set 2 V +1 04/17/23, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40813

  6. core-ci voted on patch set 3 V +1 04/17/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40815

  7. Jasmina Ließmann uploaded patch set 4 V +1 04/17/23, 16:53

  8. core-ci voted on patch set 4 V +1 04/17/23, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40821

  9. Benjamin Kott uploaded patch set 5 V +1 04/18/23, 14:40

  10. core-ci voted on patch set 5 V -1 04/18/23, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40882

  11. Benjamin Kott uploaded patch set 6 V -1 04/19/23, 09:06

  12. core-ci voted on patch set 6 V -1 04/19/23, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40893

  13. Benjamin Kott uploaded patch set 7 V -1 04/19/23, 13:29

  14. Benjamin Kott uploaded patch set 8 04/19/23, 13:40

  15. core-ci voted on patch set 7 V -1 04/19/23, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40898

  16. core-ci voted on patch set 8 V +1 04/19/23, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40899

  17. Benjamin Kott uploaded patch set 9 V +1 04/19/23, 15:07

  18. core-ci voted on patch set 9 V +1 04/19/23, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40912

  19. Benjamin Kott uploaded patch set 10 V +1 04/19/23, 15:26

  20. core-ci voted on patch set 10 V +1 04/19/23, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40913

  21. Benjamin Kott uploaded patch set 11 V +1 04/19/23, 15:36

  22. core-ci voted on patch set 11 V +1 04/19/23, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40914

  1. Benjamin Kott uploaded patch set 12 V +1 04/19/23, 15:43

  2. core-ci voted on patch set 12 V +1 04/19/23, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40915

  3. Jasmina Ließmann uploaded patch set 13 V +1 04/19/23, 17:52

  4. Jasmina Ließmann commented on patch set 13 V -1 04/19/23, 18:21

    "Active TypoScript" > if multiple TypoScript records exist on the same page the form fields are not aligned correctly anymore (select field with a label to chose a record). Side note: With the change from ".row / .col-xy" to ".form-row / .form-group" the fields are now centered vertically, but are not proper aligned anymore on mobile / tablet in some submodules in "TypoScript" and "Page TSconfig". In a previous patch I made sure form fields like "Selected record", "Selected category" or the search input always have the same width across the submodules to have a unified layout and don't jump around (https://review.typo3.org/c/Packages/TYPO3.CMS/+/78653). Now the length of the select options define the widh. --> Maybe we can combine both approaches?
  5. Jasmina Ließmann uploaded patch set 14 V -1 04/19/23, 18:39

  6. Jasmina Ließmann voted on patch set 14 V -1 04/19/23, 18:40

  7. core-ci voted on patch set 13 V +1 04/19/23, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40927

  8. core-ci voted on patch set 14 V +1 04/19/23, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40928

  9. Benjamin Kott uploaded patch set 15 V +1 04/20/23, 09:28

  10. Benjamin Kott commented on patch set 15 04/20/23, 09:32

    Reply

    Introduced .form-row variants for breakpoints and adjusted the display accordingly. The jumping in size for input fields was due a sketchy implmentation of the clearable implementation, that has been reworked to avoid layout shifts after the js was invoked. I highly disagree to limit the size of selected categories, this made long labels disappear and not readable. This needs to be reverted and streamlined.
  11. Benjamin Kott uploaded patch set 16 04/20/23, 09:41

  12. core-ci voted on patch set 15 V -1 04/20/23, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40948

  13. Benjamin Kott uploaded patch set 17 04/20/23, 09:54

  14. core-ci voted on patch set 16 V -1 04/20/23, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40951

  15. Benjamin Kott uploaded patch set 18 04/20/23, 10:06

  16. core-ci voted on patch set 17 V -1 04/20/23, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40952

  17. core-ci voted on patch set 18 V +1 04/20/23, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40953

  18. Benjamin Kott uploaded patch set 19 V +1 04/20/23, 10:17

  19. core-ci voted on patch set 19 V +1 04/20/23, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40954

  20. Andreas Kienast updated the commit message in patch set 20 V +1 04/20/23, 10:38

  21. core-ci voted on patch set 20 V +1 04/20/23, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40958

  22. Andreas Kienast voted on patch set 20 V +1 CR +1 04/20/23, 10:52

  23. Benni Mack voted on patch set 20 V +2 CR +2 04/20/23, 11:39

  24. Benni Mack merged patch set 21 04/20/23, 11:39

  25. Jasmina Ließmann commented on patch set 21 04/20/23, 13:10

    Unresolved

    Sadly the form fields in "Active TypoScript" still wobbling around if there is more than one typoscript record on the same page: https://imgur.com/a/JMuecaO