78682[TASK] Streamline spacings
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 103
- Build/Sources/Sass/component/_card.scss+2 −2
- Build/Sources/Sass/component/_checkbox.scss+10 −2
- Build/Sources/Sass/component/_code.scss+29 −1
- Build/Sources/Sass/component/_form.scss+33 −1
- Build/Sources/Sass/component/_module.scss+0 −4
- Build/Sources/Sass/component/_note.scss+3 −3
- Build/Sources/Sass/component/_pagination.scssnew+7 −0
- Build/Sources/Sass/component/_panel.scss+2 −2
- Build/Sources/Sass/component/_recordlist.scss+5 −1
- Build/Sources/Sass/component/_recordsearchbox.scss+1 −1
- Build/Sources/Sass/component/_resources.scss+2 −1
- Build/Sources/Sass/component/_root.scss+1 −1
- Build/Sources/Sass/component/_spacer.scssnew+13 −0
- Build/Sources/Sass/component/_statusreport.scss+1 −1
- Build/Sources/Sass/component/_table.scss+1 −1
- Build/Sources/Sass/component/_type.scssnew+26 −0
- Build/Sources/Sass/module/_install.scss+2 −0
- Build/Sources/Sass/module/_page.scss+1 −1
- Build/Sources/Sass/module/_scheduler.scss+0 −4
- Build/Sources/Sass/typo3/_main_content.scss+0 −13
Show 83 more files
- Build/Sources/Sass/typo3/_main_form.scss+11 −20
- Build/Sources/Sass/variables/_main.scss+9 −9
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/Sass/_minimal.scss+2 −0
- Build/Sources/TypeScript/backend/form-engine/field-control/password-generator.ts+1 −1
- Build/Sources/TypeScript/backend/input/clearable.ts+3 −1
- Build/Sources/TypeScript/backend/form-engine.ts+2 −2
- Build/Sources/TypeScript/backend/login.ts+1 −1
- Build/Sources/TypeScript/belog/backend-log.ts+2 −2
- Build/Sources/TypeScript/install/renderable/clearable.ts+3 −1
- Build/Sources/TypeScript/lowlevel/query-generator.ts+41 −38
- typo3/sysext/backend/Classes/Controller/RecordListController.php+9 −5
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+1 −0
- typo3/sysext/backend/Classes/Form/Element/EmailElement.php+1 −0
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+1 −0
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php+1 −0
- typo3/sysext/backend/Classes/Form/Element/NumberElement.php+1 −0
- typo3/sysext/backend/Classes/Form/Element/PasswordElement.php+1 −0
- typo3/sysext/backend/Resources/Private/Layouts/Module.html+4 −0
- typo3/sysext/backend/Resources/Private/Partials/About/Logo.html+5 −4
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/Login/ForgetPasswordForm.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/Login/ResetPasswordForm.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/Login/UserPassLoginForm.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/Page/NewPages.html+7 −11
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModule.html+8 −4
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModuleNoAccess.html+8 −4
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Active.html+53 −53
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Includes.html+42 −42
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/RecordsOverview.html+8 −4
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Overview.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/RecordDownloadSettings.html+37 −42
- typo3/sysext/backend/Resources/Private/Templates/RecordList.html+7 −5
- typo3/sysext/backend/Resources/Public/Css/backend.css+87 −53
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/field-control/password-generator.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/input/clearable.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/belog/Resources/Private/Partials/Content/Filter.html+14 −14
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/Filter.html+8 −8
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/Filter.html+4 −4
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/List.html+8 −10
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Show.html+11 −11
- typo3/sysext/beuser/Resources/Private/Templates/BackendUserGroup/List.html+8 −10
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html+82 −22
- typo3/sysext/core/Tests/Acceptance/Application/DbCheck/DbCheckModuleCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/RecordDownloadCest.php+3 −3
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Distributions.html+4 −6
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Index.html+3 −3
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Ter.html+3 −3
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+3 −2
- typo3/sysext/impexp/Resources/Private/Templates/Export.html+13 −9
- typo3/sysext/impexp/Resources/Private/Templates/Import.html+13 −8
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Index.html+4 −4
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Statistic.html+3 −3
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/StatisticDetails.html+9 −9
- typo3/sysext/info/Resources/Private/Templates/PageInformation.html+14 −9
- typo3/sysext/info/Resources/Private/Templates/TranslationStatus.html+27 −18
- typo3/sysext/install/Resources/Private/Templates/Environment/ImageProcessing.html+57 −58
- typo3/sysext/install/Resources/Public/JavaScript/renderable/clearable.js+1 −1
- typo3/sysext/linkvalidator/Resources/Private/Partials/LevelSelector.html+8 −10
- typo3/sysext/linkvalidator/Resources/Private/Templates/Backend/CheckLinks.html+9 −5
- typo3/sysext/linkvalidator/Resources/Private/Templates/Backend/Report.html+11 −7
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+229 −160
- typo3/sysext/lowlevel/Resources/Private/Templates/Configuration.html+5 −5
- typo3/sysext/lowlevel/Resources/Private/Templates/CustomSearch.html+14 −7
- typo3/sysext/lowlevel/Resources/Public/JavaScript/query-generator.js+1 −1
- typo3/sysext/reactions/Resources/Private/Templates/Management/Overview.html+4 −4
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule.html+5 −5
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+14 −12
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditStartEndFields.html+2 −2
- typo3/sysext/setup/Resources/Private/Templates/Main.html+7 −7
- typo3/sysext/tstemplate/Resources/Private/Partials/ActiveConditions.html+35 −39
- typo3/sysext/tstemplate/Resources/Private/Partials/ActiveOptions.html+12 −12
- typo3/sysext/tstemplate/Resources/Private/Partials/ActiveTreePanel.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerConditions.html+35 −39
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerOptions.html+2 −2
- typo3/sysext/tstemplate/Resources/Private/Partials/ConstantEditorOptions.html+3 −3
- typo3/sysext/tstemplate/Resources/Private/Templates/ActiveMain.html+8 −5
- typo3/sysext/tstemplate/Resources/Private/Templates/Analyzer.html+8 −5
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditorMain.html+7 −5
- typo3/sysext/tstemplate/Resources/Private/Templates/InfoModifyMain.html+10 −6
- typo3/sysext/webhooks/Resources/Private/Templates/Management/Overview.html+4 −4
- typo3/sysext/workspaces/Resources/Private/Partials/WorkingTable.html+6 −6
Review log 2747
Show 1122 earlier messages
-
Benjamin Kott uploaded patch set 1 04/17/23, 09:37
-
core-ci voted on patch set 1 V +1 04/17/23, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40790
-
Benjamin Kott uploaded patch set 2
V +104/17/23, 14:51 -
Benjamin Kott uploaded patch set 3 04/17/23, 14:52
-
core-ci voted on patch set 2 V +1 04/17/23, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40813
-
core-ci voted on patch set 3 V +1 04/17/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40815
-
Jasmina Ließmann uploaded patch set 4
V +104/17/23, 16:53 -
core-ci voted on patch set 4 V +1 04/17/23, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40821
-
Benjamin Kott uploaded patch set 5
V +104/18/23, 14:40 -
core-ci voted on patch set 5 V -1 04/18/23, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40882
-
Benjamin Kott uploaded patch set 6
V -104/19/23, 09:06 -
core-ci voted on patch set 6 V -1 04/19/23, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40893
-
Benjamin Kott uploaded patch set 7
V -104/19/23, 13:29 -
Benjamin Kott uploaded patch set 8 04/19/23, 13:40
-
core-ci voted on patch set 7 V -1 04/19/23, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40898
-
core-ci voted on patch set 8 V +1 04/19/23, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40899
-
Benjamin Kott uploaded patch set 9
V +104/19/23, 15:07 -
core-ci voted on patch set 9 V +1 04/19/23, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40912
-
Benjamin Kott uploaded patch set 10
V +104/19/23, 15:26 -
core-ci voted on patch set 10 V +1 04/19/23, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40913
-
Benjamin Kott uploaded patch set 11
V +104/19/23, 15:36 -
core-ci voted on patch set 11 V +1 04/19/23, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40914
-
Benjamin Kott uploaded patch set 12
V +104/19/23, 15:43 -
core-ci voted on patch set 12 V +1 04/19/23, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40915
-
Jasmina Ließmann uploaded patch set 13
V +104/19/23, 17:52 -
Jasmina Ließmann commented on patch set 13 V -1 04/19/23, 18:21
"Active TypoScript" > if multiple TypoScript records exist on the same page the form fields are not aligned correctly anymore (select field with a label to chose a record). Side note: With the change from ".row / .col-xy" to ".form-row / .form-group" the fields are now centered vertically, but are not proper aligned anymore on mobile / tablet in some submodules in "TypoScript" and "Page TSconfig". In a previous patch I made sure form fields like "Selected record", "Selected category" or the search input always have the same width across the submodules to have a unified layout and don't jump around (https://review.typo3.org/c/Packages/TYPO3.CMS/+/78653). Now the length of the select options define the widh. --> Maybe we can combine both approaches? -
Jasmina Ließmann uploaded patch set 14
V -104/19/23, 18:39 -
Jasmina Ließmann voted on patch set 14 V -1 04/19/23, 18:40
-
core-ci voted on patch set 13 V +1 04/19/23, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40927
-
core-ci voted on patch set 14 V +1 04/19/23, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40928
-
Benjamin Kott uploaded patch set 15
V +104/20/23, 09:28 -
Benjamin Kott commented on patch set 15 04/20/23, 09:32
Reply
Introduced .form-row variants for breakpoints and adjusted the display accordingly. The jumping in size for input fields was due a sketchy implmentation of the clearable implementation, that has been reworked to avoid layout shifts after the js was invoked. I highly disagree to limit the size of selected categories, this made long labels disappear and not readable. This needs to be reverted and streamlined. -
Benjamin Kott uploaded patch set 16 04/20/23, 09:41
-
core-ci voted on patch set 15 V -1 04/20/23, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40948
-
Benjamin Kott uploaded patch set 17 04/20/23, 09:54
-
core-ci voted on patch set 16 V -1 04/20/23, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40951
-
Benjamin Kott uploaded patch set 18 04/20/23, 10:06
-
core-ci voted on patch set 17 V -1 04/20/23, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40952
-
core-ci voted on patch set 18 V +1 04/20/23, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40953
-
Benjamin Kott uploaded patch set 19
V +104/20/23, 10:17 -
core-ci voted on patch set 19 V +1 04/20/23, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40954
-
Andreas Kienast updated the commit message in patch set 20
V +104/20/23, 10:38 -
core-ci voted on patch set 20 V +1 04/20/23, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40958
-
Andreas Kienast voted on patch set 20 V +1 CR +1 04/20/23, 10:52
-
Benni Mack voted on patch set 20 V +2 CR +2 04/20/23, 11:39
-
Benni Mack merged patch set 21 04/20/23, 11:39
-
Jasmina Ließmann commented on patch set 21 04/20/23, 13:10
Unresolved
Sadly the form fields in "Active TypoScript" still wobbling around if there is more than one typoscript record on the same page: https://imgur.com/a/JMuecaO