Review main Merged

78684[TASK] Use setRequest() in ContentObjectRenderer

Christian Kuhn CR +2 V +2 Normal +79 −13 updated 04/17/23, 14:52

Commit message

There are two ways of handing over the current
request to ContentObjectRenderer after instantiation:
By calling setRequest() and by handing the request
to start() as third argument.

To further streamline request handling, the patch
deprecates the second way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 13

Review log 914

  1. Christian Kuhn uploaded patch set 1 04/17/23, 12:47

  2. Christian Kuhn uploaded patch set 2 04/17/23, 13:06

  3. Christian Kuhn uploaded patch set 3 04/17/23, 13:12

  4. core-ci voted on patch set 2 V +1 04/17/23, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40806

  5. Christian Kuhn uploaded patch set 4 04/17/23, 13:19

  6. core-ci voted on patch set 3 V +1 04/17/23, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40807

  7. core-ci voted on patch set 4 V +1 04/17/23, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40808

  8. Christian Kuhn uploaded patch set 5 V +1 04/17/23, 13:53

  9. core-ci voted on patch set 5 V +1 04/17/23, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40810

  10. Benni Mack voted on patch set 5 V +1 CR +1 04/17/23, 14:15

  11. core-ci voted on patch set 1 V -1 04/17/23, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40804

  12. Stefan Bürk voted on patch set 5 V +1 CR +1 04/17/23, 14:33

  13. Christian Kuhn voted on patch set 5 V +2 CR +2 04/17/23, 14:52

  14. Christian Kuhn merged patch set 6 04/17/23, 14:52