Review main Abandoned

78693[TASK] Avoid usage of LanguageService->includeLLFile in ext:backend ContextMenuController

Anja Leichsenring CR 0 V 0 Easy +0 −14 updated 04/20/23, 07:13

Commit message

The extension does not use any globally loaded labels, so the usage
of the function to load the labels globally can safely be removed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 78

  1. Anja Leichsenring uploaded patch set 1 04/17/23, 17:38

  2. core-ci voted on patch set 1 V +1 04/17/23, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40828

  3. Christoph Lehmann voted on patch set 1 V +1 CR +1 04/17/23, 18:50

  4. Jasmina Ließmann voted on patch set 1 V +1 CR +1 04/17/23, 19:53

  5. Jörg Bösche voted on patch set 1 CR +1 04/18/23, 07:15

  6. Christian Kuhn commented on patch set 1 CR -1 04/18/23, 07:17

    I think does not work, there is for Instance a getLL() call in RecordProvider for click menu on content elements ~290 that leads to not filled $attributes array.
  7. Anja Leichsenring abandoned the change 04/20/23, 07:11

    // If a document should be duplicated.
  8. Anja Leichsenring commented on patch set 1 04/20/23, 07:13

    done in another change