Review main Abandoned

78694[TASK] Avoid usage of includeLLFile() in ext:backend EditDocumentController

Anja Leichsenring CR 0 V 0 Easy +7 −10 updated 04/20/23, 07:09

Commit message

All usage of globally loaded labels has been replaced,
so the usage of the function to load the labels globally
can safely be removed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Anja Leichsenring uploaded patch set 1 04/17/23, 18:05

  2. core-ci voted on patch set 1 V +1 04/17/23, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40830

  3. Jörg Bösche voted on patch set 1 CR +1 04/18/23, 07:27

  4. Christian Kuhn commented on patch set 1 04/18/23, 07:54

    EditDocumentController.php:688

    i'd prefer to load $title with the sL() call directly, this is more easy to search for, later.
  5. Anja Leichsenring commented on patch set 1 V -1 04/18/23, 08:09

    EditDocumentController.php:688 Reply

    Ack
  6. Anja Leichsenring abandoned the change 04/20/23, 07:09

    done in another change