Review main Merged

78712[BUGFIX] Consider EqualityInterface in SourceCollection

Oliver Hader CR +2 V +2 Normal +72 −10 updated 04/20/23, 17:21

Commit message

The behavior of `EqualityInterface` has to be applied when
comparing instances that implement this interface to find
duplicates in a `SourceCollection`.
For instance two instances of `UriValue`, that have the same
URI value could not be handled correctly - either there are
duplicates, or values cannot be removed from a collection.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Chris Müller +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Oliver Hader uploaded patch set 1 04/18/23, 03:52

  2. Oliver Hader commented on patch set 1 04/18/23, 03:53

    Tests would be great, but I dont have time for that currently
  3. core-ci voted on patch set 1 V -1 04/18/23, 04:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40839

  4. core-ci commented on patch set 1 04/18/23, 07:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40839

  5. Oliver Hader uploaded patch set 2 V -1 04/18/23, 12:56

  6. core-ci voted on patch set 2 V +1 04/18/23, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40874

  7. Chris Müller voted on patch set 2 V +1 04/18/23, 13:29

  8. Benni Mack voted on patch set 2 V +1 CR +1 04/20/23, 12:34

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 04/20/23, 16:58

  10. Oliver Hader commented on patch set 2 V +2 CR +2 04/20/23, 17:20

    Thx folks!
  11. Oliver Hader merged patch set 3 04/20/23, 17:21