Review main Merged

78713[TASK] Avoid usage of includeLLFile in ext:backend NewRecordController

Anja Leichsenring CR +2 V +2 Easy +2 −3 updated 04/18/23, 08:53

Commit message

All usage of globally loaded labels has been replaced,
so the usage of the function to load the labels globally
can safely be removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Anja Leichsenring uploaded patch set 1 04/18/23, 04:53

  2. Anja Leichsenring uploaded patch set 2 04/18/23, 04:54

  3. core-ci voted on patch set 1 V +1 04/18/23, 05:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40842

  4. core-ci voted on patch set 2 V +1 04/18/23, 05:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40843

  5. Andreas Kienast commented on patch set 2 CR -1 04/18/23, 06:35

    NewRecordController.php:411

    Looks like your clipboard did funny stuff.
  6. Anja Leichsenring uploaded patch set 3 CR -1 V +1 04/18/23, 06:39

  7. Anja Leichsenring commented on patch set 3 04/18/23, 06:40

    NewRecordController.php:411 Reply

    Done
  8. core-ci voted on patch set 3 V +1 04/18/23, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40846

  9. Jörg Bösche voted on patch set 3 CR +1 04/18/23, 07:14

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 04/18/23, 07:51

  11. Jasmina Ließmann voted on patch set 3 V +1 CR +1 04/18/23, 08:41

  12. Benni Mack voted on patch set 3 V +2 CR +2 04/18/23, 08:53

  13. Benni Mack merged patch set 4 04/18/23, 08:53