Review main Merged

78725[BUGFIX] Use ModuleProvider to check module access

Oli Bartsch CR +2 V +2 Easy +9 −5 updated 04/19/23, 08:10

Commit message

Since modules can have aliases it's necessary
to always use the ModuleProvider API for checking
the module access permissions of a backend user.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Oli Bartsch uploaded patch set 1 04/18/23, 10:02

  2. core-ci voted on patch set 1 V +1 04/18/23, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40860

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 04/18/23, 11:32

  4. Benni Mack commented on patch set 1 CR -1 04/18/23, 12:46

    one place still missing
  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 04/18/23, 14:24

  6. Oli Bartsch commented on patch set 2 04/18/23, 14:24

    Reply

    Thanks, done.
  7. core-ci voted on patch set 2 V +1 04/18/23, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40881

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 04/19/23, 06:07

  9. Jochen Roth voted on patch set 2 V +1 CR +1 04/19/23, 08:09

  10. Oli Bartsch voted on patch set 2 V +2 CR +2 04/19/23, 08:10

  11. Oli Bartsch merged patch set 3 04/19/23, 08:10