Review main Merged

78729[TASK] Prepare FormEngine towards DI

Christian Kuhn CR +2 V +2 Hard +210 −116 updated 04/20/23, 08:38

Commit message

It is possible to prepare FormEngine
towards proper dependency injection with
a relatively small patch, including good
compatibility for extensions with v11 & v12
and upwards compatibility with v12 & v13.

With TYPO3 v13, we can adapt own uses
and leverage the full power of DI.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 11

Review log 1218

  1. Christian Kuhn uploaded patch set 1 04/18/23, 15:22

  2. core-ci voted on patch set 1 V -1 04/18/23, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40883

  3. Christian Kuhn uploaded patch set 2 V -1 04/19/23, 14:33

  4. core-ci voted on patch set 2 V +1 04/19/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40906

  5. Christian Kuhn uploaded patch set 3 V +1 04/19/23, 15:47

  6. core-ci voted on patch set 3 V +1 04/19/23, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40916

  7. Christian Kuhn uploaded patch set 4 V +1 04/19/23, 16:02

  8. Christian Kuhn uploaded patch set 5 04/19/23, 16:03

  9. Christian Kuhn uploaded patch set 6 04/19/23, 16:04

  10. Christian Kuhn uploaded patch set 7 04/19/23, 16:12

  11. core-ci voted on patch set 6 V +1 04/19/23, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40920

  12. core-ci voted on patch set 7 V +1 04/19/23, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40921

  13. Christian Kuhn uploaded patch set 8 V +1 04/19/23, 16:40

  14. Stefan Bürk voted on patch set 8 V +1 CR +1 04/19/23, 16:42

  15. core-ci voted on patch set 8 V +1 04/19/23, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40923

  16. Anja Leichsenring voted on patch set 8 V +1 CR +1 04/20/23, 08:06

  17. Christian Kuhn voted on patch set 8 V +2 CR +2 04/20/23, 08:38

  18. Christian Kuhn merged patch set 9 04/20/23, 08:38