Review main Merged

78731[TASK] Deprecate ConfigurationManager->getContentObject()

Christian Kuhn CR +2 V +2 Normal +174 −34 updated 04/19/23, 14:30

Commit message

The extbase ConfigurationManager logic is still
painful. It is a stateful singleton, which
we can not dissolve at the moment.

To reduce headaches, we now deprecate the
getContentObject() misuse, a solution avoiding
this has been established with #100623.

This allows us to streamline the implementation
with TYPO3 v13 quite a bit, making it less of a
burden.

The patch deprecates the method and introduces a
setRequest() method instead. Extbase bootstrap
takes care of setting this for each plugin. We
don't get rid of the singleton state, but since
we don't add a public getRequest(), it makes
ConfigurationManager a data sink only for this
state, which can not be abused anymore.

This also allows us to get rid of
$GLOBALS['TYPO3_REQUEST'] usages within
ConfigurationManager in TYPO3 v13.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 68

  1. Christian Kuhn uploaded patch set 1 04/19/23, 11:42

  2. core-ci voted on patch set 1 V +1 04/19/23, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40895

  3. Christian Kuhn uploaded patch set 2 V +1 04/19/23, 12:30

  4. core-ci voted on patch set 2 V +1 04/19/23, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40897

  5. Benni Mack voted on patch set 2 V +1 CR +1 04/19/23, 13:01

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 04/19/23, 13:17

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 04/19/23, 14:30

  8. Christian Kuhn merged patch set 3 04/19/23, 14:30