Review main Merged

78755[TASK] Avoid getLL() usages in various system extensions

Benni Mack CR +2 V +2 Hard +197 −205 updated 04/20/23, 05:47

Commit message

Using sL() instead of getLL() shows direct dependencies
on labels and their label files within the code.

This change replaces all usages in
* extensionmanager
* form
* impexp
* install
* reports
* setup
* filelist

with sL() calls.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1016

  1. Benni Mack uploaded patch set 1 04/19/23, 14:55

  2. Benni Mack uploaded patch set 2 04/19/23, 15:00

  3. core-ci voted on patch set 1 V -1 04/19/23, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40910

  4. core-ci voted on patch set 2 V -1 04/19/23, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40911

  5. Anja Leichsenring uploaded patch set 3 V -1 04/20/23, 04:37

  6. core-ci voted on patch set 3 V +1 04/20/23, 04:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40936

  7. Anja Leichsenring uploaded patch set 4 V +1 04/20/23, 05:00

  8. Anja Leichsenring uploaded patch set 5 04/20/23, 05:03

  9. Anja Leichsenring voted on patch set 5 V +1 CR +1 04/20/23, 05:09

  10. core-ci voted on patch set 4 V -1 04/20/23, 05:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40937

  11. core-ci voted on patch set 5 V -1 04/20/23, 05:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40938

  12. Anja Leichsenring uploaded patch set 6 CR +1 V +1 04/20/23, 05:18

  13. core-ci voted on patch set 6 V +1 04/20/23, 05:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40939

  14. Anja Leichsenring voted on patch set 6 V +1 CR +1 04/20/23, 05:32

  15. Georg Ringer voted on patch set 6 V +2 CR +2 04/20/23, 05:47

  16. Georg Ringer merged patch set 7 04/20/23, 05:47