Review main Merged

78763[TASK] Use psr/http-message:"^1.1 || ^2.0"

Christian Kuhn CR +2 V +2 Hard +238 −628 updated 04/20/23, 14:26

Commit message

We should strive for current dependency versions
with upcoming 12.4.0 LTS.

psr/http-message has recently been released
as 1.1.0 and 2.0.0, which we should support.

According to [1], having ^1.1 as lower bound is
encouraged to have ^2.0.

All our implementations are @internal, dropping
1.0 shouldn't be a huge burden, and other
dependencies like guzzle adapted as well already.

The patch bumps a couple of psr dependencies to
allow ^2.0, raises guzzlehttp/psr7 to a minimum
version that supports ^1.1 and ^2.0, and sets
psr/http-message to ^1.1 || ^2.0.

Our implementations are adapted, allowing us to
be much more strict on types.

One unfortunate "nullable" Uri is left, but this
could be sorted out with a dedicated patch since
it has impact on quite a few test cases.

[1] https://www.php-fig.org/psr/psr-7/meta/#72-type-additions

> composer u psr/http-client \
             psr/http-factory \
             psr/http-server-handler \
             psr/http-server-middleware
> composer req guzzlehttp/psr7:^2.5.0
> composer req --no-update guzzlehttp/psr7:"^2.5.0" -d typo3/sysext/core
> composer req psr/http-message:"^1.1 || ^2.0"
> composer req --no-update psr/http-message:"^1.1 || ^2.0" -d typo3/sysext/adminpanel
> composer req --no-update psr/http-message:"^1.1 || ^2.0" -d typo3/sysext/core
> composer req --no-update psr/http-message:"^1.1 || ^2.0" -d typo3/sysext/form
> composer req --no-update psr/http-message:"^1.1 || ^2.0" -d typo3/sysext/redirects

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 24

Review log 1219

  1. Christian Kuhn uploaded patch set 1 04/20/23, 10:20

  2. core-ci voted on patch set 1 V -1 04/20/23, 10:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40955

  3. Christian Kuhn uploaded patch set 2 V -1 04/20/23, 11:17

  4. Christian Kuhn uploaded patch set 3 04/20/23, 11:29

  5. core-ci voted on patch set 2 V -1 04/20/23, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40959

  6. core-ci voted on patch set 3 V +1 04/20/23, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40960

  7. Christian Kuhn uploaded patch set 4 V +1 04/20/23, 12:55

  8. core-ci voted on patch set 4 V +1 04/20/23, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40963

  9. Christian Kuhn updated the commit message in patch set 5 V +1 04/20/23, 13:13

  10. Benni Mack voted on patch set 5 V +1 CR +1 04/20/23, 13:16

  11. Christian Kuhn commented on patch set 5 CR -1 04/20/23, 13:20

    temp -1 to see if nightly is happy.
  12. core-ci voted on patch set 5 V +1 04/20/23, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40966

  13. core-ci voted on patch set 5 V -1 04/20/23, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40967

  14. core-ci voted on patch set 5 V +1 04/20/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40967

  15. Christian Kuhn voted on patch set 5 CR 0 04/20/23, 14:11

  16. Oliver Klee voted on patch set 5 V +1 CR +1 04/20/23, 14:25

  17. Stefan Bürk voted on patch set 5 V +1 CR +1 04/20/23, 14:25

  18. Christian Kuhn voted on patch set 5 V +2 CR +2 04/20/23, 14:26

  19. Christian Kuhn merged patch set 6 04/20/23, 14:26