Review main Merged

78774[TASK] Mark SystemEnvironmentBuilder as @internal

Oliver Klee CR +2 V +2 Easy +1 −3 updated 04/20/23, 15:38

Commit message

This class has a human-readable comment marking it internal.
Now it also has the corresponding PHPDoc annotation so IDEs
can recognize the class as being internal, too, so that developers
using the class can see a warning in their IDEs.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Christoph Lehmann +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Christoph Lehmann +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Oliver Klee uploaded patch set 1 04/20/23, 15:28

  2. Christian Kuhn commented on patch set 2 04/20/23, 15:29

    Published edit on patch set 1.
  3. Christian Kuhn updated the commit message in patch set 3 04/20/23, 15:29

  4. Christian Kuhn voted on patch set 3 V +1 CR +1 04/20/23, 15:30

  5. Stefan Bürk voted on patch set 3 V +1 CR +1 04/20/23, 15:33

  6. Christoph Lehmann voted on patch set 3 V +1 CR +1 04/20/23, 15:36

  7. core-ci voted on patch set 3 V +1 04/20/23, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40990

  8. Stefan Bürk voted on patch set 3 V +2 CR +2 04/20/23, 15:38

  9. Stefan Bürk merged patch set 4 04/20/23, 15:38

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 04/20/23, 15:38