Review main Merged

78776[TASK] Track CSP nonce consumption

Oliver Hader CR +2 V +2 Normal +102 −36 updated 04/21/23, 22:44

Commit message

The new `ConsumableValue` class has been added, which is capable
of tracking how often a value has been used for any kind of output.
This way, it can be determined whether the nonce value would be
required at all.

This patch is a preparation for handling dynamic nonce values in
cached scenarios during the frontend rendering process.

Other occurrences of `$properties['nonce']` in `PageRenderer` were
without any specific functionality and just have been simplified.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1319

  1. Oliver Hader uploaded patch set 1 04/20/23, 16:00

  2. Oliver Klee updated the commit message in patch set 2 04/20/23, 16:05

  3. Oliver Hader updated the commit message in patch set 3 04/20/23, 16:05

  4. Oliver Hader commented on patch set 3 04/20/23, 16:08

    Accidentally overridden, will fix in next PS
  5. core-ci voted on patch set 1 V +1 04/20/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40994

  6. Oliver Hader updated the commit message in patch set 4 04/20/23, 16:09

  7. core-ci voted on patch set 4 V +1 04/20/23, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40998

  8. core-ci voted on patch set 3 V +1 04/20/23, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40997

  9. core-ci voted on patch set 2 V +1 04/20/23, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40996

  10. Oliver Hader rebased onto patch set 5 V +1 04/20/23, 17:03

  11. core-ci voted on patch set 5 V +1 04/20/23, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41003

  12. Benni Mack voted on patch set 5 V +1 CR +1 04/20/23, 20:25

  13. Oliver Hader uploaded patch set 6 CR +1 V +1 04/20/23, 20:36

  14. core-ci voted on patch set 6 V +1 04/20/23, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41010

  15. Andreas Kienast voted on patch set 6 CR +1 04/21/23, 09:14

  16. Oliver Hader commented on patch set 6 04/21/23, 12:26

    "How to test?" - In case the backend still works for you, you tested in already - backend modules use the nonce via importmaps, the referrer check (on reloading the whole backend) also uses that nonce.
  17. Christian Kuhn voted on patch set 6 V +1 CR +1 04/21/23, 14:49

  18. Oliver Hader voted on patch set 6 V +2 CR +2 04/21/23, 22:44

  19. Oliver Hader merged patch set 7 04/21/23, 22:44