78776[TASK] Track CSP nonce consumption
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oliver Hader +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Middleware/ContentSecurityPolicyHeaders.php+2 −1
- typo3/sysext/core/Classes/Domain/ConsumableString.phpnew+53 −0
- typo3/sysext/core/Classes/Http/Security/ReferrerEnforcer.php+3 −3
- typo3/sysext/core/Classes/Page/ImportMap.php+3 −2
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php+4 −3
- typo3/sysext/core/Classes/Page/PageRenderer.php+19 −15
- typo3/sysext/core/Tests/Unit/Http/Security/ReferrerEnforcerTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Page/ImportMapTest.php+10 −9
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+4 −1
- typo3/sysext/frontend/Classes/Middleware/ContentSecurityPolicyHeaders.php+2 −1
Review log 1319
-
Oliver Hader uploaded patch set 1 04/20/23, 16:00
-
Oliver Klee updated the commit message in patch set 2 04/20/23, 16:05
-
Oliver Hader updated the commit message in patch set 3 04/20/23, 16:05
-
Oliver Hader commented on patch set 3 04/20/23, 16:08
Accidentally overridden, will fix in next PS -
core-ci voted on patch set 1 V +1 04/20/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40994
-
Oliver Hader updated the commit message in patch set 4 04/20/23, 16:09
-
core-ci voted on patch set 4 V +1 04/20/23, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40998
-
core-ci voted on patch set 3 V +1 04/20/23, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40997
-
core-ci voted on patch set 2 V +1 04/20/23, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40996
-
Oliver Hader rebased onto patch set 5
V +104/20/23, 17:03 -
core-ci voted on patch set 5 V +1 04/20/23, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41003
-
Benni Mack voted on patch set 5 V +1 CR +1 04/20/23, 20:25
-
Oliver Hader uploaded patch set 6
CR +1V +104/20/23, 20:36 -
core-ci voted on patch set 6 V +1 04/20/23, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41010
-
Andreas Kienast voted on patch set 6 CR +1 04/21/23, 09:14
-
Oliver Hader commented on patch set 6 04/21/23, 12:26
"How to test?" - In case the backend still works for you, you tested in already - backend modules use the nonce via importmaps, the referrer check (on reloading the whole backend) also uses that nonce. -
Christian Kuhn voted on patch set 6 V +1 CR +1 04/21/23, 14:49
-
Oliver Hader voted on patch set 6 V +2 CR +2 04/21/23, 22:44
-
Oliver Hader merged patch set 7 04/21/23, 22:44