Review main Merged

78779[TASK] Allow doctrine/instantiator ^1.5 || ^2.0

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 04/21/23, 07:51

Commit message

v11 has "^1.4". For v12, we first removed it entirely,
and brought doctrine/instantiator back as "^2.0"
in #100207.

The "^2.0" restriction is a bit harsh, not all
other libraries caught up on this relatively
young new major.

To play well with others, we change
doctrine/instantiator to "^1.5 || ^2.0", the changes
betwen 1.5 and 2.0 [1] are mainly type
sugar that is not critical to us. The ^1.5 minor
restriction shouldn't be an issue for "sane" other
libraries which tend to go with something like "^1.0",
or "^1.3", or similar.

> composer req doctrine/instantiator:"^1.5 || ^2.0"
> composer req --no-update doctrine/instantiator:"^1.5 || ^2.0" -d typo3/sysext/extbase

[1] https://github.com/doctrine/instantiator/compare/1.5.0...2.0.0

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jörg Bösche +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 711

  1. Christian Kuhn uploaded patch set 1 04/21/23, 05:31

  2. Christian Kuhn updated the commit message in patch set 2 04/21/23, 05:33

  3. Christian Kuhn updated the commit message in patch set 3 04/21/23, 05:35

  4. Christian Kuhn updated the commit message in patch set 4 04/21/23, 05:37

  5. core-ci voted on patch set 2 V +1 04/21/23, 05:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41018

  6. core-ci voted on patch set 1 V +1 04/21/23, 05:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41017

  7. core-ci voted on patch set 4 V +1 04/21/23, 05:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41020

  8. core-ci voted on patch set 3 V +1 04/21/23, 06:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41019

  9. Jörg Bösche voted on patch set 4 V +1 CR +1 04/21/23, 07:09

  10. Stefan Bürk voted on patch set 4 V +2 CR +2 04/21/23, 07:51

  11. Stefan Bürk merged patch set 5 04/21/23, 07:51