78784[TASK] Use less memory in BE::getPagesTSconfig()
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 79
-
Christian Kuhn uploaded patch set 1 04/21/23, 11:43
-
Oliver Klee commented on patch set 1 04/21/23, 11:46
Looks very good! Just one nitpick.BackendUtility.php:741Nitpick: For both `!empty` checks, we don't need the `null` fallback, as `empty` also checks whether the array key exists. -
core-ci voted on patch set 1 V +1 04/21/23, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41030
-
Christian Kuhn uploaded patch set 2
V +104/21/23, 11:53 -
Christian Kuhn commented on patch set 1 04/21/23, 11:53
BackendUtility.php:741Replyah. true that. done. -
Oliver Klee voted on patch set 2 V +1 CR +1 04/21/23, 11:55
-
core-ci voted on patch set 2 V +1 04/21/23, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41031
-
Stefan Bürk voted on patch set 2 V +2 CR +2 04/21/23, 12:36
-
Stefan Bürk merged patch set 3 04/21/23, 12:36