Review main Merged

78786[TASK] Replace the deprecated "braces" php-cs-fixer rule

Christian Kuhn CR +2 V +2 Easy +24 −23 updated 04/21/23, 14:50

Commit message

Current php-cs-fixer notifies:

Rule "braces" is deprecated. Use "single_space_around_construct",
"control_structure_braces", "curly_braces_position",
"control_structure_continuation_position", "declare_parentheses",
"statement_indentation", "no_multiple_statements_per_line"
and "no_extra_blank_lines" instead.

Rule details:

* "single_space_around_construct" - added to config, triggers a couple of changes
* "control_structure_braces" - active via @PER rule set already
* "curly_braces_position" - active via @PER rule set already
* "control_structure_continuation_position" - active via @PER rule set already
* "declare_parentheses" - added to config, no changes
* "statement_indentation" - active via @PER rule set already
* "no_multiple_statements_per_line" - active via @PER rule set already
* "no_extra_blank_lines" - active already

Executed command:

> Build/Scripts/runTests.sh -s cgl

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 13

Review log 710

  1. Christian Kuhn uploaded patch set 1 04/21/23, 14:10

  2. Christian Kuhn updated the commit message in patch set 2 04/21/23, 14:11

  3. Oliver Klee updated the commit message in patch set 3 04/21/23, 14:11

  4. core-ci voted on patch set 1 V +1 04/21/23, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41040

  5. core-ci voted on patch set 2 V +1 04/21/23, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41041

  6. Christian Kuhn updated the commit message in patch set 4 04/21/23, 14:43

  7. Oliver Klee voted on patch set 4 V +1 CR +1 04/21/23, 14:43

  8. core-ci voted on patch set 4 V +1 04/21/23, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41043

  9. Stefan Bürk voted on patch set 4 V +2 CR +2 04/21/23, 14:50

  10. Stefan Bürk merged patch set 5 04/21/23, 14:50