Review main Merged

78788[TASK] Verify current iso data in nightly

Christian Kuhn CR +2 V +2 Hard +281 −87 updated 04/21/23, 17:04

Commit message

We established a language and country database
with related issues provided by core in v12.

Data is fetched from a debian repository,
available via sokil/php-isocodes-db-i18n.

Script Build/Scripts/updateIsoDatabase.php
creates core files based on this.

The patch adds a nightly run that fetches
latest dependencies, calls the update script
and looks if core files have been changed.

This gives us a red nightly as soon as TYPO3
files need an update due to upstream changes.

When nightly goes red, a patch should be
merged that incorporates the changes done by
this run:

> Build/Scripts/runTests.sh -s checkIsoDatabase

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 4

Files 23

Show 3 more files

Review log 814

  1. Christian Kuhn uploaded patch set 1 04/21/23, 15:21

  2. Christian Kuhn commented on patch set 1 04/21/23, 15:32

    patch set 1: pre-merge should go green nightly should go red
  3. core-ci voted on patch set 1 V +1 04/21/23, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41049

  4. core-ci voted on patch set 1 V -1 04/21/23, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41050

  5. Christian Kuhn uploaded patch set 2 V -1 04/21/23, 16:01

  6. Christian Kuhn updated the commit message in patch set 3 04/21/23, 16:05

  7. core-ci voted on patch set 2 V +1 04/21/23, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41051

  8. core-ci voted on patch set 3 V +1 04/21/23, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41052

  9. Christian Kuhn uploaded patch set 4 V +1 04/21/23, 16:17

  10. core-ci voted on patch set 4 V +1 04/21/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41057

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 04/21/23, 16:54

  12. core-ci commented on patch set 4 04/21/23, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41058

  13. Anja Leichsenring voted on patch set 4 V +2 CR +2 04/21/23, 17:04

  14. Anja Leichsenring merged patch set 5 04/21/23, 17:04