Review main Merged

78789[BUGFIX] Allow "default" next to "extensionName" in f:translate

Oli Bartsch CR +2 V +2 Easy +29 −5 updated 04/24/23, 12:11

Commit message

It's now possible again to provide a "short key",
an extension name and also a default value for
the f:translate ViewHelper in non-extbase context.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 89

  1. Oli Bartsch uploaded patch set 1 04/21/23, 16:37

  2. Christian Kuhn commented on patch set 1 CR -1 04/21/23, 16:39

    temp -1. need to investigate impact.
  3. Oli Bartsch commented on patch set 1 04/21/23, 16:40

    Reply

    Sure: VH is however covered by tests.
  4. core-ci voted on patch set 1 V +1 04/21/23, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41059

  5. Christian Kuhn voted on patch set 1 CR -2 04/21/23, 16:51

  6. Christian Kuhn voted on patch set 1 V +1 CR +1 04/24/23, 11:56

  7. Oliver Klee voted on patch set 1 V +1 04/24/23, 11:59

  8. Benni Mack commented on patch set 1 V +2 CR +2 04/24/23, 12:11

    thanks for adding a test
  9. Benni Mack merged patch set 2 04/24/23, 12:11