Review main Merged

78790[TASK] Fix exception message in PageViewHelper

Christian Eßl CR +2 V +2 Easy +6 −6 updated 04/24/23, 11:34

Commit message

PageViewHelper no longer exclusively supports extbase context
request objects. Adjust the exception message accordingly.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1317

  1. Christian Eßl uploaded patch set 1 04/21/23, 18:18

  2. Oliver Klee voted on patch set 1 CR +1 04/21/23, 18:19

  3. core-ci voted on patch set 1 V +1 04/21/23, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41060

  4. Christian Eßl uploaded patch set 2 CR +1 V +1 04/21/23, 18:29

  5. core-ci voted on patch set 2 V +1 04/21/23, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41061

  6. Oliver Klee voted on patch set 2 CR +1 04/21/23, 18:47

  7. Georg Ringer voted on patch set 2 V +1 CR +1 04/24/23, 06:09

  8. Andreas Kienast commented on patch set 3 CR +1 V +1 04/24/23, 06:12

    Published edit on patch set 2.
  9. core-ci voted on patch set 3 V +1 04/24/23, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41113

  10. Oliver Klee voted on patch set 3 CR +1 04/24/23, 08:17

  11. Christian Kuhn voted on patch set 3 CR -1 04/24/23, 11:13

  12. Christian Kuhn uploaded patch set 4 CR +1 V +1 04/24/23, 11:20

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 04/24/23, 11:20

  14. Andreas Kienast voted on patch set 4 V +1 CR +2 04/24/23, 11:25

  15. core-ci voted on patch set 4 V +1 04/24/23, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41150

  16. Andreas Kienast voted on patch set 4 V +2 04/24/23, 11:34

  17. Andreas Kienast merged patch set 5 04/24/23, 11:34