Review main Merged

78793[BUGFIX] Correctly invoke delete and mute actions of CSP module

Oliver Hader CR +2 V +2 Normal +50 −14 updated 04/24/23, 06:08

Commit message

The `deleteAction` and `muteAction` of the CSP module endpoint
expected to receive multiple `summaries` as identifiers, however
just a single `summary` was sent, and the corresponding action
was not executed on the server side.

Besides that, a new scope specific "remove all" action has been
added to the CSP module and endpoint.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 57

  1. Oliver Hader uploaded patch set 1 04/22/23, 10:56

  2. core-ci voted on patch set 1 V +1 04/22/23, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41087

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/22/23, 11:42

  4. core-ci voted on patch set 2 V +1 04/22/23, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41090

  5. Georg Ringer voted on patch set 2 V +1 CR +1 04/23/23, 06:31

  6. Benni Mack voted on patch set 2 V +2 CR +2 04/24/23, 06:08

  7. Benni Mack merged patch set 3 04/24/23, 06:08