Review main Merged

78798[BUGFIX] Do not log requests with unsupported HTTP method

Christoph Lehmann CR +2 V +2 Easy +1 −0 updated 04/24/23, 10:58

Commit message

Illegal requests should not fill log files.

The Exception is thrown in \TYPO3\CMS\Core\Http\Request::validateMethod()

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Christoph Lehmann uploaded patch set 1 04/24/23, 07:57

  2. Benni Mack commented on patch set 1 04/24/23, 08:03

    this is a pain in the butt, our sentry is full with it, I'd say this is a bugfix.
  3. core-ci voted on patch set 1 V +1 04/24/23, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41122

  4. Thomas Hohn voted on patch set 1 CR +1 04/24/23, 08:05

  5. Christoph Lehmann updated the commit message in patch set 2 CR +1 V +1 04/24/23, 08:07

  6. Christoph Lehmann commented on patch set 2 04/24/23, 08:08

    task -> bugfix
  7. Oliver Klee voted on patch set 2 CR +1 04/24/23, 08:16

  8. core-ci voted on patch set 2 V +1 04/24/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41123

  9. Torben Hansen voted on patch set 2 V +1 CR +1 04/24/23, 08:21

  10. Benni Mack voted on patch set 2 V +2 CR +2 04/24/23, 10:58

  11. Benni Mack merged patch set 3 04/24/23, 10:58