Review main Merged

78799[TASK] Deprecate various language-related methods and properties

Benni Mack CR +2 V +2 Normal +216 −20 updated 04/24/23, 14:37

Commit message

The following methods and properties have been
deprecated:

* Argument $alternativeLanguageKeys in LocalizationUtility::translate()
* <f:translate> ViewHelper argument "alternativeLanguageKeys"
* LanguageService->getLL()

The method "LanguageService->includeLLFile()" is
marked as internal.

This is done in order to streamline future development
in label-related areas.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1317

  1. Benni Mack uploaded patch set 1 04/24/23, 08:10

  2. Oliver Klee commented on patch set 1 04/24/23, 08:15

    LocalizationUtility.php:51

    We also should add a `@deprecated` annotation to the parameter to help IDEs mark usages. (I haven't checked if PhpStorm actually does this, though.)
  3. Benni Mack marked it work in progress 04/24/23, 08:16

  4. core-ci voted on patch set 1 V -1 04/24/23, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41124

  5. Benni Mack uploaded patch set 2 V -1 04/24/23, 09:14

  6. core-ci voted on patch set 2 V +1 04/24/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41131

  7. Oliver Klee commented on patch set 2 04/24/23, 09:44

    LocalizationUtility.php:51 Reply

    Done
  8. Chris Müller uploaded patch set 3 V +1 04/24/23, 10:23

  9. core-ci voted on patch set 3 V +1 04/24/23, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41142

  10. Benni Mack uploaded patch set 4 V +1 04/24/23, 10:56

  11. core-ci voted on patch set 4 V +1 04/24/23, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41144

  12. Christian Kuhn marked it ready for review 04/24/23, 13:01

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 04/24/23, 13:04

  14. Oli Bartsch voted on patch set 4 V +1 CR +1 04/24/23, 13:23

  15. Oliver Klee voted on patch set 4 V +1 04/24/23, 13:29

  16. Benni Mack voted on patch set 4 V +2 CR +2 04/24/23, 14:37

  17. Benni Mack merged patch set 5 04/24/23, 14:37