78802[BUGFIX] Check used webserver during CLI setup
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-99221-AddCliInstallSetupCommand.rst+1 −0
- typo3/sysext/install/Classes/Command/SetupCommand.php6+34 −1
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+4 −3
- typo3/sysext/install/Classes/Controller/InstallerController.php+5 −4
- typo3/sysext/install/Classes/Controller/UpgradeController.php+5 −1
- typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php12+8 −17
- typo3/sysext/install/Classes/Service/CoreUpdateService.php+4 −2
- typo3/sysext/install/Classes/WebserverType.phpnew+69 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/DefaultFactoryTest.php+3 −1
Review log 3954
Show 2129 earlier messages
-
Andreas Kienast uploaded patch set 1 04/24/23, 09:23
-
Andreas Kienast uploaded patch set 2 04/24/23, 09:24
-
Andreas Kienast uploaded patch set 3 04/24/23, 09:25
-
Andreas Kienast uploaded patch set 4 04/24/23, 09:30
-
core-ci voted on patch set 3 V -1 04/24/23, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41135
-
core-ci voted on patch set 4 V -1 04/24/23, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41137
-
Andreas Kienast uploaded patch set 5
V -104/24/23, 09:43 -
core-ci voted on patch set 5 V +1 04/24/23, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41138
-
Frank Nägler voted on patch set 5 CR +1 04/24/23, 10:07
-
Andreas Kienast uploaded patch set 6
CR +1V +104/24/23, 10:10 -
Andreas Kienast uploaded patch set 7 04/24/23, 10:10
-
core-ci voted on patch set 7 V +1 04/24/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41140
-
core-ci voted on patch set 6 V -1 04/24/23, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41139
-
Oliver Klee commented on patch set 7 04/24/23, 10:30
-
Andreas Kienast commented on patch set 7 04/24/23, 10:34
DefaultFactory.php:31ReplyYou read it wrong, please check `isApacheServer()` and `isMicrosoftIisServer()` in the same class. -
Benni Mack commented on patch set 7 04/24/23, 10:58
SetupCommand.php:54I'd say, use "other" as a synonym for "nginx"SetupCommand.php:149server-type? -
Oliver Klee commented on patch set 7 04/24/23, 11:04
DefaultFactory.php:31ReplyAh, I totally missed that this is constructor property promotion. Ack. -
Oliver Klee wrote 04/24/23, 11:05
Removed cc Oliver Klee. -
Andreas Kienast commented on patch set 7 CR -1 04/24/23, 11:12
SetupCommand.php:54ReplyAckSetupCommand.php:149ReplyAck -
Andreas Kienast uploaded patch set 8
CR -1V +104/24/23, 11:17 -
Andreas Kienast uploaded patch set 9 04/24/23, 11:19
-
core-ci voted on patch set 8 V +1 04/24/23, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41147
-
core-ci voted on patch set 9 V +1 04/24/23, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41149
-
Benni Mack updated the commit message in patch set 10
V +105/03/23, 09:46 -
Andreas Kienast rebased onto patch set 11 06/16/23, 10:20
-
core-ci voted on patch set 11 V +1 06/16/23, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42732
-
Christian Kuhn commented on patch set 11 CR -1 06/16/23, 10:45
DefaultFactory.php:32please don't: this pollutes __construct() and destroys possible future DI for this class, which would mean we'd have to have another factory if we want DI ... could we maybe have this with a setter that is called optionally to "force" web server type or something like that? maybe remove the access to the global altogether in the class somehow? -
Andreas Kienast commented on patch set 11 06/16/23, 12:19
DefaultFactory.php:32ReplyIf we want to get rid of $_SERVER in this class, the setter cannot be optional. Will push a new patch set. -
Andreas Kienast uploaded patch set 12
CR -1V +106/16/23, 12:25
-
core-ci voted on patch set 12 V -1 06/16/23, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42740
-
Andreas Kienast uploaded patch set 13
V -106/16/23, 12:43 -
core-ci voted on patch set 13 V +1 06/16/23, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42741
-
Andreas Kienast rebased onto patch set 14
V +107/28/23, 05:57 -
core-ci voted on patch set 14 V +1 07/28/23, 06:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44638
-
Christian Kuhn commented on patch set 14 07/28/23, 17:56
DefaultFactory.php:32ReplyDone -
Christian Kuhn commented on patch set 14 CR -1 07/28/23, 17:59
DefaultFactory.php:42better: hand over $serverType as required argument to this method! this will this class stateless and does not need a setter. -
Stefan Bürk commented on patch set 14 07/28/23, 18:11
DefaultFactory.php:42ReplyShould be also passed to the called methods. -
Helmut Hummel commented on patch set 14 08/14/23, 11:22
DefaultFactory.php:42ReplyAgreed. The argument should be an optional enum (see other comment). It has to be optional to not break the API. By default, no file should be created (enum value UNKNOWN maybe?)DefaultFactory.php:411I would encapsulate this logic along with all different options into a backed enum. The enum could have factories for a request and maybe a factory for a cli input (to remove the duplication for pulling that info out of SERVER_SOFTWARE -
Stefan Bürk commented on patch set 14 CR -1 08/15/23, 14:25
on it ... -
Stefan Bürk uploaded patch set 15
CR -1V +108/15/23, 15:28 -
Stefan Bürk commented on patch set 15 08/15/23, 15:31
Reply
DoneDefaultFactory.php:42ReplyEnum is a good idea. However, this class is internal. So it's not public api. Therefore, no need to have a optional default handling here.DefaultFactory.php:411ReplyAck + Done. -
core-ci voted on patch set 15 V -1 08/15/23, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45512
-
Stefan Bürk uploaded patch set 16
V -108/15/23, 15:58 -
core-ci voted on patch set 16 V +1 08/15/23, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45513
-
Stefan Bürk uploaded patch set 17
V +108/15/23, 16:08 -
core-ci voted on patch set 17 V +1 08/15/23, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45514
-
Stefan Bürk voted on patch set 17 V +1 CR +1 08/17/23, 14:51
-
Stefan Bürk voted on patch set 17 V 0 CR -1 08/30/23, 07:37
-
Stefan Bürk uploaded patch set 18
CR -1V +108/30/23, 15:26 -
core-ci voted on patch set 18 V +1 08/30/23, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46049
-
Nikita Hovratov voted on patch set 18 V +1 CR +1 08/31/23, 07:54
-
Andreas Kienast commented on patch set 18 08/31/23, 08:20
SetupCommand.php:503IMO we're mixing validation and normalization here, but no hard blocker. -
Stefan Bürk commented on patch set 18 V +2 CR +2 08/31/23, 09:24
SetupCommand.php:503ReplyDone -
Stefan Bürk merged patch set 19 08/31/23, 09:37
DefaultFactory.php:31