Review main Merged

78804[BUGFIX] Allow untrusted query arguments in ViewHelpers

Oli Bartsch CR +2 V +2 Normal +188 −38 updated 04/24/23, 16:32

Commit message

With #98488, the typolink option "addQueryString" changed
the behaviour to only add mapped query arguments by default.
To add all - even "untrusted" - arguments to the generated
URL, the new "untrusted" keyword has to be used.

This now adds the possibility to set the new keyword in
all related ViewHelpers. Therefore, the "addQueryString"
property of the extbase UriBuilder is adjusted as well.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 1014

  1. Oli Bartsch uploaded patch set 1 04/24/23, 10:56

  2. core-ci voted on patch set 1 V +1 04/24/23, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41143

  3. Oli Bartsch uploaded patch set 2 V +1 04/24/23, 13:02

  4. Oli Bartsch uploaded patch set 3 04/24/23, 13:16

  5. Benni Mack voted on patch set 3 CR +1 04/24/23, 13:22

  6. core-ci voted on patch set 2 V -1 04/24/23, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41163

  7. Oli Bartsch uploaded patch set 4 CR +1 04/24/23, 13:26

  8. core-ci voted on patch set 4 V -1 04/24/23, 13:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41167

  9. Oli Bartsch uploaded patch set 5 V -1 04/24/23, 15:06

  10. core-ci voted on patch set 5 V +1 04/24/23, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41175

  11. Benni Mack voted on patch set 5 V +1 CR +1 04/24/23, 15:51

  12. Stefan Bürk voted on patch set 5 CR +1 04/24/23, 16:24

  13. Stefan Bürk voted on patch set 5 V +2 CR +2 04/24/23, 16:32

  14. Stefan Bürk merged patch set 6 04/24/23, 16:32