Review main Merged

78807[TASK] Streamline several CSP aspects

Oliver Hader CR +2 V +2 Easy +25 −9 updated 04/24/23, 12:51

Commit message

This is a collection of some smaller adjustments of CSP aspects:

* move `ScopeRepository` to `ext:core` (it will be useful later)
* add `ScopeRepository::findAllFrontendSites()` (site-specific)
* mark `Site::$site` and `Site::frontendSite($site)` as `@internal`
  both aspects are probably not required and might be removed later
* add case `MutationOriginType::site` (site-specific mutations)
* remove duplicate `*.google.com` URI from `GoogleMapsHandler`

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1012

  1. Oliver Hader uploaded patch set 1 04/24/23, 12:07

  2. core-ci voted on patch set 1 V +1 04/24/23, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41154

  3. Benni Mack voted on patch set 1 V +1 CR +1 04/24/23, 12:28

  4. Markus Klein voted on patch set 1 CR +1 04/24/23, 12:36

  5. Markus Klein commented on patch set 2 CR +1 V +1 04/24/23, 12:36

    Published edit on patch set 1.
  6. Markus Klein commented on patch set 2 V +1 CR +1 04/24/23, 12:37

    only added a missing LF
  7. Markus Klein commented on patch set 3 CR +1 V +1 04/24/23, 12:37

    Published edit on patch set 2.
  8. Markus Klein voted on patch set 3 V +1 CR +1 04/24/23, 12:37

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 04/24/23, 12:39

  10. core-ci voted on patch set 3 V +1 04/24/23, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41160

  11. Benni Mack voted on patch set 3 V +2 CR +2 04/24/23, 12:51

  12. Benni Mack merged patch set 4 04/24/23, 12:51