Review main Merged

78810[TASK] Allow f:asset.css and f:asset.script to use CSP nonce

Oliver Hader CR +2 V +2 Easy +17 −9 updated 04/24/23, 15:52

Commit message

Adds new boolean `useNonce` attribute to asset view helpers, e.g.
`<f:asset.css useNonce="1">` or `<f:asset.script useNonce="1">`.
This way the `AssetRenderer` is instructed to apply the global
dynamic nonce value.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1013

  1. Oliver Hader uploaded patch set 1 04/24/23, 13:51

  2. core-ci voted on patch set 1 V +1 04/24/23, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41169

  3. Oliver Hader uploaded patch set 2 V +1 04/24/23, 14:29

  4. core-ci voted on patch set 2 V +1 04/24/23, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41172

  5. Oliver Klee commented on patch set 2 04/24/23, 15:14

    The issue ID is still missing.
  6. Oliver Hader uploaded patch set 3 V +1 04/24/23, 15:24

  7. Oliver Hader commented on patch set 3 04/24/23, 15:26

    Reply

    Thx. I was fully aware of that and it happened on purpose.
  8. core-ci voted on patch set 3 V +1 04/24/23, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41176

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 04/24/23, 15:36

  10. Oliver Klee wrote 04/24/23, 15:36

    Removed cc Oliver Klee.
  11. Georg Ringer voted on patch set 3 CR +1 04/24/23, 15:41

  12. Benni Mack voted on patch set 3 V +2 CR +2 04/24/23, 15:51

  13. Benni Mack merged patch set 4 04/24/23, 15:52