Review 11.5 Merged

78812[BUGFIX] Fix PHP 8 warning in LinkValidatorController

Stefan Bürk CR +2 V +2 Easy +27 −6 updated 04/24/23, 16:27

Commit message

The variable $row['url_response']['errorParams'] should always contain
a value. Either the actual error message array or an empty array to
avoid a PHP 8 warning.
The corresponding getErrorMessage methods now have a guard clause to
check if the array is empty to avoid further propagated warnings.
In TYPO3 v13 that signature of the getErrorMessage should be changed to
be array.

The array $errorParams is always initialized to an empty array instead
of null. IN TYPO3 v13 the default value of $errorParams should be []
instead of null.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 34

  1. Stefan Bürk uploaded patch set 1 04/24/23, 16:18

  2. core-ci voted on patch set 1 V +1 04/24/23, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41178

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 04/24/23, 16:27

  4. Stefan Bürk merged patch set 2 04/24/23, 16:27