Review main Merged

78815[TASK] Provide composer.json to fixture extensions in ext:backend

Anja Leichsenring CR +2 V +2 Normal +79 −52 updated 04/27/23, 09:38

Commit message

In preparation of composer based test setups, all fixture extensions
require fully functional `composer.json` files.

For starters, the minimal required `composer.json` is added. We will
adjust as we go. Extensions without classes don't receive PSR-4
class loading definitions as those are not needed.

As a convention, all fixture extensions have their extension name
start with `test_`, and their composer name will use the vendor `typo3tests`.

Classes will have the vendor `TYPO3Tests`.

This way, fixture extensions are easy to identify, both by providing
tests that use the extensions, as well as in development to not accidentally use such an extension or class.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1115

  1. Anja Leichsenring uploaded patch set 1 04/24/23, 18:44

  2. Oliver Klee commented on patch set 1 04/24/23, 18:55

    composer.json:6

    I propose not having the typo3/cms-core requirement in the test extensions. This will reduce the work when we release a new core version. (For test extension where the requirement is needed for the test to make sense, we should of course keep the requirement.)
  3. Stefan Bürk commented on patch set 1 04/24/23, 19:04

    composer.json:6 Reply

    This is a preparation towards composer based test instances. Therefore, I would say this make sense to have this in there. I guess that this would be handled with the release script / darth anyway (or we can add it there then). Set this to resolved. Feel free to reopening it, if there is more to discuss.
  4. core-ci voted on patch set 1 V -1 04/24/23, 19:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41187

  5. Anja Leichsenring updated the commit message in patch set 2 V -1 04/24/23, 19:11

  6. Anja Leichsenring uploaded patch set 3 04/24/23, 19:18

  7. core-ci voted on patch set 3 V -1 04/24/23, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41190

  8. Anja Leichsenring uploaded patch set 4 V -1 04/27/23, 04:47

  9. core-ci voted on patch set 4 V +1 04/27/23, 04:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41264

  10. Oliver Klee voted on patch set 4 V +1 04/27/23, 08:28

  11. Oliver Klee updated the commit message in patch set 5 V +1 04/27/23, 08:30

  12. Oliver Klee voted on patch set 5 V +1 CR +1 04/27/23, 08:31

  13. core-ci voted on patch set 5 V +1 04/27/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41265

  14. Stefan Bürk voted on patch set 5 V +2 CR +2 04/27/23, 09:38

  15. Stefan Bürk merged patch set 6 04/27/23, 09:38