78840[BUGFIX] Avoid exceptions while loading presets
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1320
-
TYPO3com uploaded patch set 1 04/25/23, 11:48
-
Simon Gilli updated the commit message in patch set 2 04/25/23, 11:51
-
Oliver Klee updated the commit message in patch set 3 04/25/23, 11:51
-
Oliver Klee voted on patch set 3 CR +1 04/25/23, 11:51
-
Simon Gilli updated the commit message in patch set 4
CR +104/25/23, 11:52 -
Oli Bartsch updated the commit message in patch set 5 04/25/23, 11:54
-
core-ci voted on patch set 2 V +1 04/25/23, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41211
-
core-ci voted on patch set 3 V +1 04/25/23, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41212
-
Oliver Klee voted on patch set 5 CR +1 04/25/23, 12:06
-
core-ci voted on patch set 1 V +1 04/25/23, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41210
-
Oli Bartsch commented on patch set 5 CR -1 04/25/23, 12:08
Seems as the adjusted code does not exist in v11.InArrayViewHelper.php:37Should we also change the allowed type to array instead of mixed? -
core-ci voted on patch set 5 V +1 04/25/23, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41214
-
Oliver Klee updated the commit message in patch set 6
CR +1V +104/25/23, 12:13 -
Oliver Klee commented on patch set 6 04/25/23, 12:14
Reply
Done -
core-ci voted on patch set 4 V +1 04/25/23, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41213
-
Simon Gilli commented on patch set 6 04/25/23, 12:23
Reply
Oops, was meant for main only.InArrayViewHelper.php:37ReplyI have no idea about the impact. In my case an empty string was given. There are 3 other usages of this VH which all will provide an array or an empty string afais. Wouldn't change it in the first place though. -
core-ci voted on patch set 6 V +1 04/25/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41216
-
Christian Kuhn commented on patch set 6 V +1 CR +1 04/25/23, 13:28
InArrayViewHelper.php:37Replyi'd keep it as proposed for now. -
Oli Bartsch voted on patch set 6 V +2 CR +2 04/25/23, 13:57
-
Oli Bartsch merged patch set 7 04/25/23, 13:57