Review main Merged

78878[BUGFIX] Recursive INCLUDE_TYPOSCRIPT with extensions

Georg Ringer CR +2 V +2 Easy +36 −2 updated 05/01/23, 08:43

Commit message

If files are used given like `news.setup.typoscript`
and the TypoScript inclusion is used with
`extension="setup.typoscript"`, the proper files
must be allowed.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1824

  1. Georg Ringer uploaded patch set 1 04/26/23, 10:47

  2. Georg Ringer commented on patch set 1 04/26/23, 10:47

    This change is ready for review.
  3. Oliver Klee updated the commit message in patch set 2 04/26/23, 10:51

  4. Oliver Klee updated the commit message in patch set 3 04/26/23, 10:51

  5. Oliver Klee commented on patch set 3 04/26/23, 10:52

    Please let's cover this with an automated test.
  6. core-ci voted on patch set 1 V -1 04/26/23, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41247

  7. Oliver Klee commented on patch set 3 04/26/23, 10:58

    Reply

    (unresolving the comment as it is not yet resolved)
  8. core-ci voted on patch set 3 V -1 04/26/23, 11:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41249

  9. Christian Kuhn commented on patch set 3 04/26/23, 11:44

    additional test is must-have. plus a check if that was really supported in v11.
  10. core-ci voted on patch set 2 V -1 04/26/23, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41248

  11. Georg Ringer uploaded patch set 4 V -1 04/26/23, 13:26

  12. Georg Ringer commented on patch set 4 04/26/23, 13:26

    Reply

    sorry but yes of course this was supported in v11. *all* of your projects are doing it this way. I will add a unit test later
  13. core-ci voted on patch set 4 V +1 04/26/23, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41252

  14. Oliver Klee updated the commit message in patch set 5 V +1 04/26/23, 13:41

  15. Oliver Klee commented on patch set 5 04/26/23, 13:42

    Reply

    Done
  16. core-ci voted on patch set 5 V +1 04/26/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41253

  17. Christian Kuhn uploaded patch set 6 V +1 04/27/23, 10:14

  18. Christian Kuhn commented on patch set 6 04/27/23, 10:15

    added a test instead of changing an existing one.
  19. core-ci voted on patch set 6 V +1 04/27/23, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41266

  20. Georg Ringer voted on patch set 6 V +1 CR +1 04/27/23, 10:23

  21. Christian Kuhn voted on patch set 6 V +1 CR +1 04/27/23, 10:35

  22. Oliver Klee voted on patch set 6 V +1 04/27/23, 10:36

  23. Stefan Bürk voted on patch set 6 V +2 CR +2 05/01/23, 08:43

  24. Stefan Bürk merged patch set 7 05/01/23, 08:43