Review main Merged

78883[BUGFIX] Handle https in url for felogin redirect mode 'refererDomains'

Ayke Halder CR +2 V +2 Easy +2 −2 updated 07/24/23, 13:18

Commit message

The `redirectMode=refererDomains` configuration allows to process a
redirect after a successful login to an evaluated referer value.

This patch fixes the evaluation of https urls as referer value. Without
this patch only http urls are evaluated correctly.

Also do not match hostnames that contain an invalid underscore in name.

Additionally the regex matching for the domain was not quoting the
configured domain names and thereby matching dots as 'any single
character' instead of a dot.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1115

  1. Ayke Halder uploaded patch set 1 04/27/23, 15:09

  2. Ayke Halder updated the commit message in patch set 2 04/27/23, 15:12

  3. core-ci voted on patch set 1 V +1 04/27/23, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41273

  4. core-ci voted on patch set 2 V +1 04/27/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41274

  5. Benni Mack voted on patch set 2 CR +1 05/02/23, 10:44

  6. Benni Mack updated the commit message in patch set 3 CR +1 V +1 05/03/23, 09:50

  7. Benni Mack rebased onto patch set 4 07/06/23, 08:39

  8. Benni Mack rebased onto patch set 5 07/06/23, 10:19

  9. core-ci voted on patch set 5 V +1 07/06/23, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43683

  10. core-ci commented on patch set 5 07/06/23, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43683

  11. Benni Mack voted on patch set 5 V +1 CR +1 07/24/23, 12:21

  12. Torben Hansen voted on patch set 5 V +1 CR +1 07/24/23, 12:24

  13. Oliver Klee voted on patch set 5 CR +1 07/24/23, 12:33

  14. Benni Mack voted on patch set 5 V +2 CR +2 07/24/23, 13:18

  15. Benni Mack merged patch set 6 07/24/23, 13:18