Review main Merged

78889[BUGFIX] Avoid TypeError in extbase persistence

Oli Bartsch CR +2 V +2 Easy +27 −4 updated 05/02/23, 10:45

Commit message

Properly check for the given value being an object before
passing it to corresponding method, which is type-hinted
since #100068.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 2024

  1. Oli Bartsch uploaded patch set 1 04/28/23, 14:46

  2. core-ci voted on patch set 1 V -1 04/28/23, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41299

  3. Oli Bartsch uploaded patch set 2 V -1 04/28/23, 15:43

  4. core-ci voted on patch set 2 V +1 04/28/23, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41302

  5. Markus Klein voted on patch set 2 V +1 CR +1 04/28/23, 16:10

  6. Jochen Roth voted on patch set 2 V +1 CR +1 04/28/23, 16:42

  7. Oliver Klee voted on patch set 2 CR +1 04/28/23, 17:00

  8. Oliver Klee commented on patch set 2 04/28/23, 17:01

    Would it make sense to backport this to 11.5 to avoid the incorrect code path (even if it does not throw a type error in 11.5)?
  9. Oliver Klee commented on patch set 2 CR 0 04/28/23, 17:04

    And I'd really like to get this covered with a regression test.
  10. Markus Klein commented on patch set 2 04/28/23, 17:49

    Reply

    +1

    Backend.php:175

    I guess we should add NULL here too
  11. Oli Bartsch commented on patch set 2 04/28/23, 20:38

    Backend.php:175 Reply

    Why do you think so? The expected type is "object", NULL does not make sense here and should IMO not be suggested. We should better try to type hint the argument (v13).
  12. Oli Bartsch uploaded patch set 3 CR +1 V +1 04/28/23, 20:52

  13. Oli Bartsch commented on patch set 3 04/28/23, 20:52

    Reply

    Done

    Reply

    Done
  14. core-ci voted on patch set 3 V -1 04/28/23, 21:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41304

  15. Oliver Klee commented on patch set 3 CR -1 04/29/23, 18:49

    on it
  16. Oliver Klee uploaded patch set 4 CR -1 V -1 04/29/23, 18:59

  17. Oliver Klee commented on patch set 4 V +1 CR +1 04/29/23, 19:00

    Backend.php:175 Reply

    Ack
  18. Oliver Klee rebased onto patch set 5 CR +1 V +1 05/02/23, 07:46

  19. Oliver Klee voted on patch set 5 V +1 CR +1 05/02/23, 07:47

  20. core-ci voted on patch set 5 V +1 05/02/23, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41337

  21. Markus Klein voted on patch set 4 V +1 CR +1 05/02/23, 08:10

  22. Benni Mack voted on patch set 5 V +1 CR +1 05/02/23, 10:43

  23. Oli Bartsch voted on patch set 5 V +2 CR +2 05/02/23, 10:45

  24. Oli Bartsch merged patch set 6 05/02/23, 10:45