Review main Merged

78890[TASK] Provide meaningful error messages for misconfigured SelectViewHelper

Nikita Hovratov CR +2 V +2 Normal +115 −31 updated 07/17/23, 12:17

Commit message

If either optionValueField or optionLabelField is not set for array
option values, the ViewHelper is not correctly configured and is
throwing now a meaningful exception message.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1417

  1. Nikita Hovratov uploaded patch set 1 04/28/23, 15:20

  2. core-ci voted on patch set 1 V +1 04/28/23, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41300

  3. Oliver Klee commented on patch set 1 04/28/23, 18:06

    Issue ID missing - is this still a WIP?
  4. Nikita Hovratov commented on patch set 1 04/30/23, 15:47

    Reply

    It's actually a fix for https://forge.typo3.org/issues/100774 But another patch is already provided for it https://review.typo3.org/c/Packages/TYPO3.CMS/+/78889 imo both patches are needed, so either I will create a new issue for this, or the other one needs a new issue.
  5. Nikita Hovratov updated the commit message in patch set 2 V +1 05/02/23, 16:27

  6. core-ci voted on patch set 2 V +1 05/02/23, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41358

  7. Benni Mack updated the commit message in patch set 3 V +1 05/03/23, 09:50

  8. Oliver Klee commented on patch set 3 07/16/23, 08:36

    As the other change is merged, do we still need this change here?
  9. Nikita Hovratov commented on patch set 3 07/17/23, 07:07

    Reply

    imo, yes as this provides a meaningful error message.
  10. Oliver Klee voted on patch set 3 V +1 CR +1 07/17/23, 07:19

  11. Christian Kuhn rebased onto patch set 4 CR +1 V +1 07/17/23, 11:09

  12. Christian Kuhn commented on patch set 4 07/17/23, 11:09

    missing ci vote - rebased to get one.
  13. Oliver Klee voted on patch set 4 V +1 CR +1 07/17/23, 11:12

  14. core-ci voted on patch set 4 V +1 07/17/23, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44209

  15. Christian Kuhn voted on patch set 4 V +1 CR +1 07/17/23, 11:24

  16. Nikita Hovratov voted on patch set 4 V +2 CR +2 07/17/23, 12:17

  17. Nikita Hovratov merged patch set 5 07/17/23, 12:17