78890[TASK] Provide meaningful error messages for misconfigured SelectViewHelper
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1417
-
Nikita Hovratov uploaded patch set 1 04/28/23, 15:20
-
core-ci voted on patch set 1 V +1 04/28/23, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41300
-
Oliver Klee commented on patch set 1 04/28/23, 18:06
Issue ID missing - is this still a WIP? -
Nikita Hovratov commented on patch set 1 04/30/23, 15:47
Reply
It's actually a fix for https://forge.typo3.org/issues/100774 But another patch is already provided for it https://review.typo3.org/c/Packages/TYPO3.CMS/+/78889 imo both patches are needed, so either I will create a new issue for this, or the other one needs a new issue. -
Nikita Hovratov updated the commit message in patch set 2
V +105/02/23, 16:27 -
core-ci voted on patch set 2 V +1 05/02/23, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41358
-
Benni Mack updated the commit message in patch set 3
V +105/03/23, 09:50 -
Oliver Klee commented on patch set 3 07/16/23, 08:36
As the other change is merged, do we still need this change here? -
Nikita Hovratov commented on patch set 3 07/17/23, 07:07
Reply
imo, yes as this provides a meaningful error message. -
Oliver Klee voted on patch set 3 V +1 CR +1 07/17/23, 07:19
-
Christian Kuhn rebased onto patch set 4
CR +1V +107/17/23, 11:09 -
Christian Kuhn commented on patch set 4 07/17/23, 11:09
missing ci vote - rebased to get one. -
Oliver Klee voted on patch set 4 V +1 CR +1 07/17/23, 11:12
-
core-ci voted on patch set 4 V +1 07/17/23, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44209
-
Christian Kuhn voted on patch set 4 V +1 CR +1 07/17/23, 11:24
-
Nikita Hovratov voted on patch set 4 V +2 CR +2 07/17/23, 12:17
-
Nikita Hovratov merged patch set 5 07/17/23, 12:17