78891[BUGFIX] Pass the full page record to the ConditionMatcher
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1316
-
Oli Bartsch uploaded patch set 1 04/28/23, 15:28
-
core-ci voted on patch set 1 V +1 04/28/23, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41301
-
Jochen Roth updated the commit message in patch set 2
V +104/28/23, 16:55 -
core-ci voted on patch set 2 V +1 04/28/23, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41303
-
Jochen Roth voted on patch set 2 V +1 CR +1 04/28/23, 17:04
-
Benni Mack voted on patch set 2 V +1 CR +1 04/28/23, 17:10
-
Christian Kuhn commented on patch set 2 04/28/23, 19:56
-
Oli Bartsch commented on patch set 2 04/28/23, 20:32
TypoScriptFrontendController.php:1237ReplyWhat's wrong about using $this->page in the first place? -
Christian Kuhn commented on patch set 2 05/02/23, 06:43
TypoScriptFrontendController.php:1237Replynothing. it's just yet-another method dependency that we need to take care off when extracting the ts compilation from tsfe, so i think we should hint about it. in general, it does not make much sense that rootline does not contain all fields - and that's a detail i'd love to fix in v13 anyway. -
Oli Bartsch uploaded patch set 3
CR +1V +105/02/23, 09:35 -
Jochen Roth voted on patch set 3 V +1 CR +1 05/02/23, 09:37
-
Oli Bartsch commented on patch set 2 05/02/23, 09:38
TypoScriptFrontendController.php:1237ReplyAdded corresponding comment. However, I'm not quite sure why we should enrich the rootline rows. IMO necessary fields are available and it can furthermore be extended with "FE/addRootLineFields". Without knowing I assume not resolving all fields was done intentionally, most likely due to performance reasons on large installations. -
Christian Kuhn commented on patch set 3 V +1 CR +1 05/02/23, 09:48
TypoScriptFrontendController.php:1237Replyi'd *love* to get rid of addRootLineFields entirely: This one is very ugly for integrators and the sole reason to have it is the imperformant thing in RootlineUtility, which we can potentially resolve more quickly. When that is done, there is no reason to not simply fetch all fields anymore. I'll optimize this with v13. -
core-ci voted on patch set 3 V +1 05/02/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41341
-
Oli Bartsch voted on patch set 3 V +2 CR +2 05/02/23, 10:19
-
Oli Bartsch merged patch set 4 05/02/23, 10:19
TypoScriptFrontendController.php:1237