Review main Merged

78891[BUGFIX] Pass the full page record to the ConditionMatcher

Oli Bartsch CR +2 V +2 Easy +4 −1 updated 05/02/23, 10:19

Commit message

The PageLayoutResolver, which is used for
"tree.pagelayout" TypoScript conditions
requires the passed page record to contain
the "backend_layout" field value.

Since this field is by default not a
rootline field, the TSFE->page array
is now passed again instead of the
shrinked record from the rootline.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1316

  1. Oli Bartsch uploaded patch set 1 04/28/23, 15:28

  2. core-ci voted on patch set 1 V +1 04/28/23, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41301

  3. Jochen Roth updated the commit message in patch set 2 V +1 04/28/23, 16:55

  4. core-ci voted on patch set 2 V +1 04/28/23, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41303

  5. Jochen Roth voted on patch set 2 V +1 CR +1 04/28/23, 17:04

  6. Benni Mack voted on patch set 2 V +1 CR +1 04/28/23, 17:10

  7. Christian Kuhn commented on patch set 2 04/28/23, 19:56

    TypoScriptFrontendController.php:1237

    please add a comment that we're using $this->page here since it contains the full table row and not just what rootlineUtility has per-row, and that we could switch to $this->rootLine as soon as rootline is changed to have all fields (which is possible without penalty, i have a wip for that which actually increases performance).
  8. Oli Bartsch commented on patch set 2 04/28/23, 20:32

    TypoScriptFrontendController.php:1237 Reply

    What's wrong about using $this->page in the first place?
  9. Christian Kuhn commented on patch set 2 05/02/23, 06:43

    TypoScriptFrontendController.php:1237 Reply

    nothing. it's just yet-another method dependency that we need to take care off when extracting the ts compilation from tsfe, so i think we should hint about it. in general, it does not make much sense that rootline does not contain all fields - and that's a detail i'd love to fix in v13 anyway.
  10. Oli Bartsch uploaded patch set 3 CR +1 V +1 05/02/23, 09:35

  11. Jochen Roth voted on patch set 3 V +1 CR +1 05/02/23, 09:37

  12. Oli Bartsch commented on patch set 2 05/02/23, 09:38

    TypoScriptFrontendController.php:1237 Reply

    Added corresponding comment. However, I'm not quite sure why we should enrich the rootline rows. IMO necessary fields are available and it can furthermore be extended with "FE/addRootLineFields". Without knowing I assume not resolving all fields was done intentionally, most likely due to performance reasons on large installations.
  13. Christian Kuhn commented on patch set 3 V +1 CR +1 05/02/23, 09:48

    TypoScriptFrontendController.php:1237 Reply

    i'd *love* to get rid of addRootLineFields entirely: This one is very ugly for integrators and the sole reason to have it is the imperformant thing in RootlineUtility, which we can potentially resolve more quickly. When that is done, there is no reason to not simply fetch all fields anymore. I'll optimize this with v13.
  14. core-ci voted on patch set 3 V +1 05/02/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41341

  15. Oli Bartsch voted on patch set 3 V +2 CR +2 05/02/23, 10:19

  16. Oli Bartsch merged patch set 4 05/02/23, 10:19