Review 12.4 Merged

78897[BUGFIX] Don't try to render icon for empty identifier

Nikita Hovratov CR +2 V +2 Easy +5 −1 updated 05/05/23, 09:20

Commit message

In case a site is missing a proper site
configuration - having no default language
a fallback SiteLanguage object is used in
the page module. This fallback however does
provide an empty string as flag identifier,
which does no longer result in a broken icon.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Nikita Hovratov commented on patch set 1 05/05/23, 08:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/05/23, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41602

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 05/05/23, 09:19

  4. Nikita Hovratov merged patch set 2 05/05/23, 09:20