Review 12.4 Merged

78898[BUGFIX] Change selector to get container in `files` element

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 05/05/23, 09:32

Commit message

The identifier used to get a container in `type=files` based on
`querySelector()` which flawed if the identifier contained a dot.
The example identifier "#foo-data-foo.bar" resulted in "find an
element with id 'foo-data-foo', having the class 'bar'", which
is wrong.

To solve this issue, while still limiting the scope to the web
component, the selector is changed to use the `[id='']` syntax,
which doesn't show the erroneous behavior.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Nikita Hovratov commented on patch set 1 05/05/23, 09:23

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/05/23, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41605

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 05/05/23, 09:32

  4. Nikita Hovratov merged patch set 2 05/05/23, 09:32