Review main Merged

78914[TASK] Provide composer.json to fixture extensions in ext:core

Anja Leichsenring CR +2 V +2 Hard +464 −63 updated 05/05/23, 04:18

Commit message

In preparation of composer based test setups, all fixture extensions
require fully functional `composer.json` files.

For starters, the minimal required `composer.json` is added. We will
adjust as we go. Extensions without classes don't receive PSR-4
class loading definitions as those are not needed.

As a convention, all fixture extensions have their composer name use the vendor `typo3tests`.

Classes will have the vendor `TYPO3Tests`.

This way, fixture extensions are easy to identify, both by providing
tests that use the extensions, as well as in development to not accidentally use such an extension or class.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 63

Show 43 more files

Review log 1621

  1. Anja Leichsenring uploaded patch set 1 05/02/23, 05:58

  2. core-ci voted on patch set 1 V -1 05/02/23, 06:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41327

  3. Anja Leichsenring uploaded patch set 2 V -1 05/02/23, 06:18

  4. Anja Leichsenring uploaded patch set 3 05/02/23, 06:19

  5. Anja Leichsenring uploaded patch set 4 05/02/23, 06:29

  6. core-ci voted on patch set 3 V -1 05/02/23, 06:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41330

  7. core-ci voted on patch set 4 V +1 05/02/23, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41332

  8. Oliver Klee voted on patch set 4 V +1 05/02/23, 07:34

  9. Oliver Klee voted on patch set 4 CR +1 05/02/23, 07:45

  10. Benni Mack updated the commit message in patch set 5 CR +1 V +1 05/03/23, 09:50

  11. Anja Leichsenring uploaded patch set 6 05/04/23, 04:23

  12. core-ci voted on patch set 6 V +1 05/04/23, 04:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41564

  13. Stefan Bürk commented on patch set 6 05/04/23, 04:53

    composer.json:7

    Should be "13.0.*@dev" now, same for other files ...
  14. Anja Leichsenring uploaded patch set 7 V +1 05/04/23, 04:55

  15. core-ci voted on patch set 7 V +1 05/04/23, 05:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41565

  16. Anja Leichsenring commented on patch set 7 05/04/23, 05:07

    composer.json:7 Reply

    Done
  17. Stefan Bürk voted on patch set 7 V +1 CR +1 05/04/23, 05:22

  18. Oliver Klee voted on patch set 7 V +1 05/04/23, 08:00

  19. Oliver Klee voted on patch set 7 CR +1 05/04/23, 08:00

  20. Anja Leichsenring voted on patch set 7 V +2 CR +2 05/05/23, 04:18

  21. Anja Leichsenring merged patch set 8 05/05/23, 04:18