Review main Merged

78916[BUGFIX] Fix caching performance issues for MySQL on large sites

Oliver Hader CR +2 V +2 Hard +91 −380 updated 11/21/23, 22:05

Commit message

Removed special treatment of MySQL connections which caused extremely
inefficient join deletes and Backend crashes on large sites with more
than about 10.000 pages.

Additionally, some mockings and dbms exclusions are removed in the
functional test. Because we do not have a dbms agnostic code switch
anymore, `*Mysql()` and `*nonMysql()` test variants are combined to
avoid superflous running tests twice.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2129

Show 24 earlier messages
  1. Oliver Hader uploaded patch set 1 05/02/23, 09:29

  2. core-ci voted on patch set 1 V -1 05/02/23, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41340

  3. Stefan Bürk rebased onto patch set 2 V -1 09/26/23, 09:45

  4. core-ci voted on patch set 2 V -1 09/26/23, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47174

  1. Stefan Bürk uploaded patch set 3 V -1 09/26/23, 16:30

  2. Stefan Bürk commented on patch set 3 CR -1 09/26/23, 16:33

    still on it ...
  3. core-ci voted on patch set 3 V -1 09/26/23, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47194

  4. Stefan Bürk uploaded patch set 4 CR -1 V -1 09/27/23, 11:25

  5. Stefan Bürk commented on patch set 4 09/27/23, 11:25

    Reply

    Done
  6. Stefan Bürk updated the commit message in patch set 5 09/27/23, 11:31

  7. core-ci voted on patch set 4 V +1 09/27/23, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47233

  8. core-ci voted on patch set 5 V +1 09/27/23, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47234

  9. Oliver Klee voted on patch set 5 V +1 09/27/23, 11:42

  10. Stefan Bürk uploaded patch set 6 V +1 09/27/23, 11:51

  11. core-ci voted on patch set 6 V +1 09/27/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47238

  12. core-ci voted on patch set 5 V +1 09/27/23, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47235

  13. Andreas Kienast voted on patch set 6 CR +1 09/27/23, 12:28

  14. Stefan Bürk voted on patch set 6 V +1 CR +1 09/27/23, 13:56

  15. Oliver Klee voted on patch set 6 V +1 10/12/23, 08:34

  16. Christoph Lehmann voted on patch set 6 CR +1 10/24/23, 17:19

  17. Jörg Bösche voted on patch set 6 CR +1 10/27/23, 06:52

  18. Guido Schmechel voted on patch set 6 CR +1 10/28/23, 09:47

  19. Julian Mair voted on patch set 6 CR +1 11/06/23, 14:32

  20. Stefan Bürk commented on patch set 6 11/21/23, 14:41

    I will remove the 11.5 backport. The impact is a little risky. It's possible to use composer patches to backport it manually if needed.
  21. Stefan Bürk uploaded patch set 7 CR +1 V +1 11/21/23, 14:41

  22. core-ci voted on patch set 7 V +1 11/21/23, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49238

  23. Christian Kuhn voted on patch set 7 V +1 CR +1 11/21/23, 19:39

  24. Stefan Bürk voted on patch set 7 V +2 CR +2 11/21/23, 21:55

  25. Stefan Bürk merged patch set 8 11/21/23, 22:05