Review main Merged

78920[BUGFIX] Ensure content object is available in UriBuilder

Oli Bartsch CR +2 V +2 Easy +30 −2 updated 05/02/23, 15:58

Commit message

Since #100623, the content object might be NULL
as it is no longer set up when initializing the
UriBuilder, but instead when handing in the
current PSR-7 request.

This patch adds a fallback for v12 to ensure
having the content object available when
generating frontend urls.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1012

  1. Oli Bartsch uploaded patch set 1 05/02/23, 13:58

  2. Benni Mack voted on patch set 1 CR +1 05/02/23, 14:01

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 05/02/23, 14:04

  4. Benni Mack voted on patch set 1 V +1 05/02/23, 14:04

  5. Christian Kuhn commented on patch set 1 05/02/23, 14:06

    UriBuilder.php:688

    i'd personally skip getContentObject() method entirely and inline this to the consuming method, but that's ok, too.
  6. core-ci voted on patch set 1 V -1 05/02/23, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41355

  7. Oli Bartsch uploaded patch set 2 CR +1 V +1 05/02/23, 14:56

  8. core-ci voted on patch set 2 V +1 05/02/23, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41357

  9. Benni Mack voted on patch set 2 V +1 CR +1 05/02/23, 15:11

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 05/02/23, 15:11

  11. Oli Bartsch voted on patch set 2 V +2 CR +2 05/02/23, 15:58

  12. Oli Bartsch merged patch set 3 05/02/23, 15:58