Review 12.4 Merged

78927[BUGFIX] Adjust Content-Security-Policy reports check for SVG files

Oliver Hader CR +2 V +2 Easy +29 −6 updated 05/15/23, 16:00

Commit message

Issue #93884 provided and adjusted CSP header for SVG inline styles:
| default-src 'self'; script-src 'none';
| style-src 'unsafe-inline'; object-src 'none';

For SVG files, having 'unsafe-inline' for style-src is fine, since
it only applies to the very same file and cannot include other local
or remote resources.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 59

  1. Oliver Hader uploaded patch set 1 05/03/23, 13:08

  2. core-ci voted on patch set 1 V -1 05/03/23, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41535

  3. Oliver Hader rebased onto patch set 2 V -1 05/03/23, 21:32

  4. core-ci voted on patch set 2 V +1 05/03/23, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41553

  5. core-ci commented on patch set 2 05/03/23, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41555

  6. Oliver Hader rebased onto patch set 3 V +1 05/15/23, 15:43

  7. core-ci voted on patch set 3 V +1 05/15/23, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41838

  8. Oliver Hader voted on patch set 3 V +2 CR +2 05/15/23, 16:00

  9. Oliver Hader merged patch set 4 05/15/23, 16:00